1693905 - Ensure AppMenu panel is usable when using high contrast themes

Status: RESOLVED FIXED

(Firefox :: Menus, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Similar to bug 1693904, but specifically for the AppMenu.

Comment 1

[Molly Howell (she/her) (no longer active)]

I tried all four of the Windows 10 built-in high contrast mode themes. In the three dark themes, the main background and foreground are correct, as are panel title bars, subheaders inside menus, the separators, the zoom controls, and the submenu indicator arrows. With all that working, the menu is mostly usable. I have found a few problems though:

• The highlight background doesn't get the system color, so it's not possible to read the text of highlighted items; since it's dark mode, you get white text on a light gray highlight.
• Disabled menu items don't get the system color, so they're very dark gray and really not legible at all.
• The keyboard shortcut text isn't the system color; it's bright enough to be legible to me, but it doesn't meet AA.
• The app menu notification banners don't have much contrast, but they aren't any better in the non-Proton app menu, so that's not a new regression.

The one built-in light (black-on-white) high contrast theme looks fine, I didn't see anything to worry about there.

Comment 2

[Molly Howell (she/her) (no longer active)]

Attachment: "High Contrast Black" theme app menu screenshot

Screenshot illustrating a few of the issues, and a few things that aren't issues.

Comment 3

[Molly Howell (she/her) (no longer active)]

Bug 1693702 is probably going to fix at least one or two of these points, so this needs to be rechecked after that.

Comment 4

[Molly Howell (she/her) (no longer active)]

Everything I had found wrong here before is now fixed, presumably by bug 1694384, except for the notification background colors, and those are going to be updated in bug 1692040, so there's nothing left to do here.