Wrong allegro.pl search engine url
Categories
(Firefox :: Search, defect, P2)
Tracking
()
People
(Reporter: bisag79981, Assigned: standard8)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr78+
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0
Steps to reproduce:
Install allegro search engine
Use allegro search engine to search
Actual results:
Firefox redirect to https://allegro.pl/listing/listing.php?string={searchTerms}&sourceid=Mozilla-search
Expected results:
Firefox redirect to https://allegro.pl/listing?string={searchTerms}&sourceid=Mozilla-search
Reporter | ||
Comment 1•3 years ago
|
||
Reporter | ||
Comment 2•3 years ago
|
||
Currently "old" url is redirected by allegro (301) to the new one, but this causes problems with encoding some characters (e.g.. spaces)
Comment 3•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Search' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Comment 4•3 years ago
|
||
(In reply to bisag79981 from comment #0)
Install allegro search engine
Install from where? Or are you using a Polish build of FIrefox?
Having said that, it looks like the URL should be fixed in mozilla-central.
Assignee | ||
Comment 5•3 years ago
|
||
Thank you for the report, I can reproduce, we'll look into getting this fixed.
Assignee | ||
Comment 6•3 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1eefce785515 Update search engine url for allegro.pl. r=mak
Comment 8•3 years ago
|
||
bugherder |
Assignee | ||
Comment 9•3 years ago
|
||
Comment on attachment 9204878 [details]
Bug 1694060 - Update search engine url for allegro.pl. r?mak!
Beta/Release Uplift Approval Request
- User impact if declined: Users of the pl or new szl locale may not be able to search properly using the application provided allegro.pl engine.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Minor change to a URL only.
The URLs themselves aren't covered by automated tests, but we do validate the engine definitions are valid.
- String changes made/needed: None
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Search engine url update, with simple fix
- User impact if declined: Users of the pl locale may not be able to search properly using the application provided allegro.pl engine.
- Fix Landed on Version: 88
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Minor change to a URL only.
The URLs themselves aren't covered by automated tests, but we do validate the engine definitions are valid.
- String or UUID changes made by this patch: None
Assignee | ||
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Comment on attachment 9204878 [details]
Bug 1694060 - Update search engine url for allegro.pl. r?mak!
Approved for 87.0b3.
Comment 11•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Comment 12•3 years ago
•
|
||
Checked issue using an old version of firefox nightly 88 from last week (PL) localized.
Verified fix using (PL localized version of firefox) on windows10 64bit, MacOS 10.15 and ubuntu 20 64bi on Firefox Beta 87b4 , Firefox Nightly 88.0a1 , and Firefox Release 86
Comment 13•3 years ago
|
||
Comment on attachment 9204878 [details]
Bug 1694060 - Update search engine url for allegro.pl. r?mak!
Approved for 78.9esr.
Comment 14•3 years ago
|
||
bugherder uplift |
Description
•