Closed Bug 1694092 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27721 - bind-gen: Apply ToV8Traits to IDL callback function

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27721 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27721
Details from upstream follow.

b'Canon Mukai <canonmukai@google.com>' wrote:

bind-gen: Apply ToV8Traits to IDL callback function

Applies ToV8Traits, a new system to convert a blink value to
a V8 value, to IDL callback function and callback interface.

Also fixes audio-encoder.any.js.
EncodedAudioChunkOutputCallback takes decoder_config as optional.
New ToV8 supports IDLOptional. If the argument for a callback function
is "missing", ToV8 returns undefined, not null.

Bug: 1172074
Change-Id: Ic63a8e4ed89f9d25b86254b1017f10374a19a8d1
Reviewed-on: https://chromium-review.googlesource.com/2711748
WPT-Export-Revision: 77ca5baa46e90c53b03d02c5800fcd5a455f89b4

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL : 3

Chrome

PASS : 3
ERROR: 1

Safari

OK : 1
FAIL : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/audio-encoder.any.html
Simple audio encoding: FAIL (Chrome: PASS, Safari: FAIL)
Encoding and decoding: FAIL (Chrome: PASS, Safari: FAIL)
Emit decoder config and extra data.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0d96c6a3b92
[wpt PR 27721] - bind-gen: Apply ToV8Traits to IDL callback function, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c0d96c6a3b92

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.