Closed Bug 1694241 Opened 3 years ago Closed 3 years ago

Adapt our notification bar styles after landing of bug 1693979

Categories

(Thunderbird :: Upstream Synchronization, task)

Tracking

(thunderbird_esr78 unaffected, thunderbird88 affected)

RESOLVED FIXED
88 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird88 --- affected

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1693979 changed some styles we are overriding. The most important is the addition of the min-height: 40px; on notification. And we can remove the button height override.

I leave the change https://hg.mozilla.org/mozilla-central/rev/384439beb5fac812a416d2d76d3d3a7ad2e3204b#l1.50 as it is. This moves the icon a bit more inside and this makes the gap almost the same as the gap of the close button.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9204671 - Flags: review?(alessandro)
Comment on attachment 9204671 [details] [diff] [review]
1694241-adapt-notification.patch

Review of attachment 9204671 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.
Did you check if the removal of the button height affects anything on macOS or Windows?
I remember on macOS we had the problem of those notification buttons not having a padding at all and being super narrow.
Attachment #9204671 - Flags: review?(alessandro) → review+

Did you check if the removal of the button height affects anything on macOS
or Windows?
I remember on macOS we had the problem of those notification buttons not
having a padding at all and being super narrow.

No problem. I removed only the rule they changed to our value: https://hg.mozilla.org/mozilla-central/rev/384439beb5fac812a416d2d76d3d3a7ad2e3204b#l1.77

Target Milestone: --- → 88 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/1a40c3dd9d77
Adapt our notification bar styles after landing of bug 1693979. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: