1694248 - Disable OMTP

Matt Woodrow (:mattwoodrow)

Assignee

Description

•

3 years ago

Now that we're shipping WebRender to most users, OMTP is adding a lot of complexity for little gain.

We should start by disabling it, and then remove the code once that's shipped.

Matt Woodrow (:mattwoodrow)

Assignee

Comment 1

•

3 years ago

Attached file Bug 1694248 - Disable OMTP. r?jrmuizel — Details

Phabricator Automation

Updated

•

3 years ago

Assignee: nobody → matt.woodrow

Status: NEW → ASSIGNED

Pulsebot

Comment 2

•

3 years ago

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd917f920d7f
Disable OMTP. r=jrmuizel

Sandor Molnar[:smolnar]

Comment 3

•

3 years ago

Backed out for causing wpt failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/916497e295fe6c3b5e8082045add889fd555dff6

Push with failures

Failure log WR3

Failure log WR2

Flags: needinfo?(matt.woodrow)

Pulsebot

Comment 4

•

3 years ago

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b5d84e2fd50
Disable OMTP. r=jrmuizel

Cosmin Sabou [:CosminS]

Comment 5

•

3 years ago

Backed out for causing wpt reftests failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=web%2Cplatform%2Creftest&tochange=d031e888c05e0dca05eb6c6a3ada116cef2e48f8&fromchange=5b5d84e2fd5052b794130e71a08450c0105ae0d4&selectedTaskRun=aXF0XYF1Ta6QHobKmtXleQ.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=330867853&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=330870423&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=330869079&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/ec61670998b6d8af70d9eea1c88a5ef6fd96fb89

Pulsebot

Comment 6

•

3 years ago

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d437a982d6a
Disable OMTP. r=jrmuizel

Sandor Molnar[:smolnar]

Comment 7

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/2d437a982d6a

Status: ASSIGNED → RESOLVED

Closed: 3 years ago

status-firefox88: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 88 Branch

Bogdan Tara[:bogdan_tara | bogdant]

Comment 8

•

3 years ago

•

Edited

Backed out changeset 2d437a982d6a (bug 1694248) for Windows 10 x64 debug xpcshell failures.

This backout was tested on try before being pushed to autoland: https://treeherder.mozilla.org/jobs?repo=try&revision=fd456f96a4493833e4d5e3952d9c89d355623959&selectedTaskRun=RLw1t7TtRZe5u39-9QAQow.0

Failures on mozilla-central: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&fromchange=27f574662450a376801f6fdd0c9184c745eb4303&searchStr=windows%2C10%2Cx64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-windows10-64%2Fdebug-xpcshell-e10s&tochange=abe97e99af31153bb9507b66e9898c6de6824345&selectedTaskRun=bFafLtuSSiW8LN9kSKCing.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/c4fccfb97a4e5e6bc528e622203ffca21c9622ab

Failure log: https://treeherder.mozilla.org/logviewer?job_id=331506515&repo=mozilla-central&lineNumber=4964

task 2021-02-28T01:38:46.737Z] 01:38:46     INFO -  TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_quota_exceeded_errors.js
[task 2021-02-28T01:38:47.555Z] 01:38:47     INFO -  rmtree() failed for "(u'\\\\?\\c:\\users\\task_1614475371\\appdata\\local\\temp\\xpc-plugins-rmjxzo',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2021-02-28T01:38:48.254Z] 01:38:48     INFO -  rmtree() failed for "(u'\\\\?\\c:\\users\\task_1614475371\\appdata\\local\\temp\\xpc-plugins-rmjxzo',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2021-02-28T01:38:49.430Z] 01:38:49     INFO -  rmtree() failed for "(u'\\\\?\\c:\\users\\task_1614475371\\appdata\\local\\temp\\xpc-plugins-rmjxzo',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2021-02-28T01:38:51.147Z] 01:38:51     INFO -  rmtree() failed for "(u'\\\\?\\c:\\users\\task_1614475371\\appdata\\local\\temp\\xpc-plugins-rmjxzo',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2021-02-28T01:38:53.301Z] 01:38:53     INFO -  rmtree() failed for "(u'\\\\?\\c:\\users\\task_1614475371\\appdata\\local\\temp\\xpc-plugins-rmjxzo',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2021-02-28T01:38:54.004Z] 01:38:54     INFO -  TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_content_sync.js | took 12612ms
[task 2021-02-28T01:38:54.990Z] 01:38:54     INFO -  TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_managed.js
[task 2021-02-28T01:38:55.954Z] 01:38:55     INFO -  Failed to remove directory: c:\users\task_1614475371\appdata\local\temp\xpc-plugins-rmjxzo. Waiting.
[task 2021-02-28T01:38:56.005Z] 01:38:56     INFO -  TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_content_sync_kinto.js | took 14116ms
[task 2021-02-28T01:38:56.005Z] 01:38:56  WARNING -  PROCESS-CRASH | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_background_generated_reload.js | application crashed [@ NS_DebugBreak(unsigned int, char const*, char const*, char const*, int)]
[task 2021-02-28T01:38:56.006Z] 01:38:56     INFO -  Mozilla crash reason: MOZ_CRASH()
[task 2021-02-28T01:38:56.006Z] 01:38:56     INFO -  Crash dump filename: c:\users\task_1614475371\appdata\local\temp\xpc-other-adpd7j\1c05b7f2-eaa2-47d0-98b8-4e16e61829dd.dmp
[task 2021-02-28T01:38:56.006Z] 01:38:56     INFO -  Operating system: Windows NT
[task 2021-02-28T01:38:56.006Z] 01:38:56     INFO -                    10.0.17134
[task 2021-02-28T01:38:56.007Z] 01:38:56     INFO -  CPU: amd64
[task 2021-02-28T01:38:56.007Z] 01:38:56     INFO -       family 6 model 85 stepping 7
[task 2021-02-28T01:38:56.007Z] 01:38:56     INFO -       8 CPUs
[task 2021-02-28T01:38:56.007Z] 01:38:56     INFO -  GPU: UNKNOWN
[task 2021-02-28T01:38:56.008Z] 01:38:56     INFO -  Crash reason:  EXCEPTION_BREAKPOINT
[task 2021-02-28T01:38:56.008Z] 01:38:56     INFO -  Crash address: 0x25da780a
[task 2021-02-28T01:38:56.008Z] 01:38:56     INFO -  Assertion: Unknown assertion type 0x00000000
[task 2021-02-28T01:38:56.008Z] 01:38:56     INFO -  Process uptime: 6 seconds
[task 2021-02-28T01:38:56.009Z] 01:38:56     INFO -  Thread 18 (crashed)
[task 2021-02-28T01:38:56.009Z] 01:38:56     INFO -   0  mozglue.dll!mozalloc_abort(char const* const) [mozalloc_abort.cpp:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 33 + 0x0]
[task 2021-02-28T01:38:56.009Z] 01:38:56     INFO -      rax = 0x00007ffb25e55e2b   rdx = 0x00007ffb3a3fa640
[task 2021-02-28T01:38:56.009Z] 01:38:56     INFO -      rcx = 0x0000000000000000   rbx = 0x0000000031898100
[task 2021-02-28T01:38:56.010Z] 01:38:56     INFO -      rsi = 0x0000002596d6f108   rdi = 0x00007ffb3a3207b0
[task 2021-02-28T01:38:56.010Z] 01:38:56     INFO -      rbp = 0x0000000000000000   rsp = 0x0000002596d6f070
[task 2021-02-28T01:38:56.010Z] 01:38:56     INFO -       r8 = 0x0000002596d6d378    r9 = 0x0000002596d6e951
[task 2021-02-28T01:38:56.010Z] 01:38:56     INFO -      r10 = 0x0000000000000000   r11 = 0x0000002596d6ef20
[task 2021-02-28T01:38:56.011Z] 01:38:56     INFO -      r12 = 0x00007ffb026ac5f8   r13 = 0x0000002596d6f9af
[task 2021-02-28T01:38:56.011Z] 01:38:56     INFO -      r14 = 0x0000000000000001   r15 = 0x0000002596d6f418
[task 2021-02-28T01:38:56.011Z] 01:38:56     INFO -      rip = 0x00007ffb25da780a
[task 2021-02-28T01:38:56.011Z] 01:38:56     INFO -      Found by: given as instruction pointer in context
[task 2021-02-28T01:38:56.012Z] 01:38:56     INFO -   1  xul.dll!NS_DebugBreak(unsigned int, char const*, char const*, char const*, int) [nsDebugImpl.cpp:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 398 + 0x4e]
[task 2021-02-28T01:38:56.012Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.012Z] 01:38:56     INFO -      rsp = 0x0000002596d6f0b0   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.012Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.013Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffaf8e9c2cb
[task 2021-02-28T01:38:56.013Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.013Z] 01:38:56     INFO -   2  xul.dll!mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/dom/media/ipc/RemoteDecoderManagerChild.cpp:88:59'>::Run() [nsThreadUtils.h:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 534 + 0x33]
[task 2021-02-28T01:38:56.013Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.014Z] 01:38:56     INFO -      rsp = 0x0000002596d6f760   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.014Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.014Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffafc748ed7
[task 2021-02-28T01:38:56.015Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.015Z] 01:38:56     INFO -   3  xul.dll!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 1152 + 0xd]
[task 2021-02-28T01:38:56.015Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.015Z] 01:38:56     INFO -      rsp = 0x0000002596d6f790   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.016Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.016Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffaf8fedb45
[task 2021-02-28T01:38:56.016Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.016Z] 01:38:56     INFO -   4  xul.dll!NS_ProcessNextEvent(nsIThread*, bool) [nsThreadUtils.cpp:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 548 + 0x14]
[task 2021-02-28T01:38:56.016Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.017Z] 01:38:56     INFO -      rsp = 0x0000002596d6f980   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.017Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.017Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffaf8ff4e52
[task 2021-02-28T01:38:56.018Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.018Z] 01:38:56     INFO -   5  xul.dll!mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [MessagePump.cpp:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 302 + 0xa]
[task 2021-02-28T01:38:56.018Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.018Z] 01:38:56     INFO -      rsp = 0x0000002596d6f9d0   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.018Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.018Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffaf98d8c57
[task 2021-02-28T01:38:56.018Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.018Z] 01:38:56     INFO -   6  xul.dll!MessageLoop::RunHandler() [message_loop.cc:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 328 + 0x8]
[task 2021-02-28T01:38:56.018Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.019Z] 01:38:56     INFO -      rsp = 0x0000002596d6fa40   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.019Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.019Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffaf9870540
[task 2021-02-28T01:38:56.019Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.020Z] 01:38:56     INFO -   7  xul.dll!MessageLoop::Run() [message_loop.cc:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 310 + 0x5]
[task 2021-02-28T01:38:56.020Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.020Z] 01:38:56     INFO -      rsp = 0x0000002596d6fa90   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.020Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.021Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffaf9870402
[task 2021-02-28T01:38:56.021Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.021Z] 01:38:56     INFO -   8  xul.dll!static nsThread::ThreadFunc(void*) [nsThread.cpp:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 391 + 0x8]
[task 2021-02-28T01:38:56.021Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.022Z] 01:38:56     INFO -      rsp = 0x0000002596d6fae0   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.022Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.022Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffaf8fe9fb4
[task 2021-02-28T01:38:56.022Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.023Z] 01:38:56     INFO -   9  nss3.dll!PR_NativeRunThread(void*) [pruthr.c:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 399 + 0xe]
[task 2021-02-28T01:38:56.023Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.023Z] 01:38:56     INFO -      rsp = 0x0000002596d6fcc0   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.023Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.023Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffb25bc0342
[task 2021-02-28T01:38:56.024Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.024Z] 01:38:56     INFO -  10  nss3.dll!pr_root(void*) [w95thred.c:7be47f00f8cfb94c2fbf68c094ddf7071a24bc44 : 139 + 0xd]
[task 2021-02-28T01:38:56.024Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.024Z] 01:38:56     INFO -      rsp = 0x0000002596d6fd40   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.025Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.025Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffb25bb0ce1
[task 2021-02-28T01:38:56.025Z] 01:38:56     INFO -      Found by: call frame info
[task 2021-02-28T01:38:56.025Z] 01:38:56     INFO -  11  ucrtbase.dll!RtlpHpSegPageRangeShrink + 0xda
[task 2021-02-28T01:38:56.026Z] 01:38:56     INFO -      rbx = 0x0000000031898100   rbp = 0x0000000000000000
[task 2021-02-28T01:38:56.026Z] 01:38:56     INFO -      rsp = 0x0000002596d6fd70   r12 = 0x00007ffb026ac5f8
[task 2021-02-28T01:38:56.026Z] 01:38:56     INFO -      r13 = 0x0000002596d6f9af   r14 = 0x0000000000000001
[task 2021-02-28T01:38:56.026Z] 01:38:56     INFO -      r15 = 0x0000002596d6f418   rip = 0x00007ffb3a32c4be
[task 2021-02-28T01:38:56.027Z] 01:38:56     INFO -      Found by: call frame info
...

Bogdan Tara[:bogdan_tara | bogdant]

Updated

•

3 years ago

Status: RESOLVED → REOPENED

status-firefox88: fixed → ---

Resolution: FIXED → ---

Target Milestone: 88 Branch → ---

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 9

•

3 years ago

Backout merged: https://hg.mozilla.org/mozilla-central/rev/c4fccfb97a4e

Alexandru Ionescu (needinfo me) [:alexandrui]

Comment 10

•

3 years ago

(In reply to Pulsebot from comment #6)

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d437a982d6a
Disable OMTP. r=jrmuizel

== Change summary for alert #28956 (as of Mon, 01 Mar 2021 10:48:01 GMT) ==

Regressions:

Ratio	Suite	Platform	Options	Absolute values (old vs new)
79%	rasterflood_svg	windows10-64-shippable	e10s stylo	10,614.88 -> 19,002.88
68%	rasterflood_svg	windows10-64-shippable	e10s stylo	11,305.28 -> 18,998.91
51%	rasterflood_svg	linux1804-64-shippable	e10s stylo	9,972.90 -> 15,070.00
49%	rasterflood_svg	linux64-shippable	e10s stylo	9,906.34 -> 14,801.51
44%	rasterflood_gradient	linux64-shippable	e10s stylo	1,364.08 -> 757.17
44%	rasterflood_gradient	linux1804-64-shippable	e10s stylo	1,336.15 -> 746.33
18%	tsvg_static	linux64-shippable	e10s stylo	49.07 -> 58.09
9%	tsvgx	windows10-64-shippable	e10s stylo	125.07 -> 136.52
8%	pdfpaint	windows10-64-shippable	e10s stylo	432.80 -> 466.87
5%	tp5o	linux1804-64-shippable	e10s stylo	237.87 -> 249.77
5%	tabswitch	windows10-64-shippable	e10s stylo	11.72 -> 12.29

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
9%	tsvgx		linux64-shippable	e10s stylo	182.77 -> 167.01
3%	tp5o_scroll		linux64-shippable-qr	e10s stylo webrender-sw	1.91 -> 1.85

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28956

Alexandru Ionescu (needinfo me) [:alexandrui]

Updated

•

3 years ago

Keywords: perf-alert

Andra Esanu (needinfo me)

Comment 11

•

3 years ago

== Change summary for alert #28961 (as of Mon, 01 Mar 2021 11:47:59 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
3%	Heap Unclassified		windows10-64-shippable		45,157,144.12 -> 43,879,139.36
2%	Heap Unclassified		windows10-64-shippable		45,142,589.47 -> 44,056,462.23

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28961

Alexandru Ionescu (needinfo me) [:alexandrui]

Comment 12

•

3 years ago

== Change summary for alert #28928 (as of Fri, 26 Feb 2021 17:59:52 GMT) ==

Regressions:

Ratio	Suite	Platform	Options	Absolute values (old vs new)
7%	raptor-motionmark-htmlsuite-firefox	windows10-64-shippable	nocondprof	32.73 -> 30.57
4%	raptor-motionmark-htmlsuite-firefox	linux1804-64-shippable	nocondprof	27.02 -> 25.81
4%	raptor-motionmark-htmlsuite-firefox	linux64-shippable	nocondprof	29.69 -> 28.54

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28928

Matt Woodrow (:mattwoodrow)

Assignee

Comment 13

•

3 years ago

Attached file Bug 1694248 - Don't assert if PBackground has been shut down when we try to create an RDD thread. r?bryce — Details

This can fail if PBackground has been shut down, while the message was queued between threads.
It happens sometimes during xpcshell tests, and disabling OMTP makes it more common (but is unrelated, just changes timings).

The actual LaunchRDDProcessIfNeeded code also gracefully handles this failure mode, so not asserting shouldn't be a problem.

Depends on D106053

Pulsebot

Comment 14

•

3 years ago

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/354aeecd6463
Disable OMTP. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/e16ad489f8d2
Don't assert if PBackground has been shut down when we try to create an RDD thread. r=bryce

Matt Woodrow (:mattwoodrow)

Assignee

Updated

•

3 years ago

Flags: needinfo?(matt.woodrow)

Ionuț Goldan [:igoldan]

Comment 15

•

3 years ago

Backout from comment #8 cancelled the regressions mentioned in comment #12.

== Change summary for alert #28977 (as of Tue, 02 Mar 2021 03:13:48 GMT) ==

Improvements:

Ratio	Suite	Platform	Options	Absolute values (old vs new)
7%	raptor-motionmark-htmlsuite-firefox	windows10-64-shippable	nocondprof	30.99 -> 33.26
5%	raptor-motionmark-htmlsuite-firefox	linux1804-64-shippable	nocondprof	25.75 -> 26.91
4%	raptor-motionmark-htmlsuite-firefox	linux64-shippable	nocondprof	28.55 -> 29.61

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28977

Alexandru Ionescu (needinfo me) [:alexandrui]

Comment 16

•

3 years ago

(In reply to Pulsebot from comment #14)

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/354aeecd6463
Disable OMTP. r=jrmuizel

== Change summary for alert #28976 (as of Tue, 02 Mar 2021 03:06:06 GMT) ==

Improvements:

Ratio	Suite	Platform	Options	Absolute values (old vs new)
74%	rasterflood_gradient	linux1804-64-shippable	e10s stylo	744.17 -> 1,292.50
74%	rasterflood_gradient	linux64-shippable	e10s stylo	757.42 -> 1,314.08
40%	rasterflood_svg	windows10-64-shippable	e10s stylo	18,992.05 -> 11,365.38
31%	rasterflood_svg	linux1804-64-shippable	e10s stylo	15,066.16 -> 10,388.13
30%	rasterflood_svg	linux64-shippable	e10s stylo	14,793.89 -> 10,301.34
14%	tsvg_static	linux64-shippable	e10s stylo	57.35 -> 49.13
10%	pdfpaint	windows10-64-shippable	e10s stylo	467.09 -> 418.88
5%	tp5o	linux1804-64-shippable	e10s stylo	250.48 -> 237.31

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28976

Andra Esanu (needinfo me)

Comment 17

•

3 years ago

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #9)

Backout merged: https://hg.mozilla.org/mozilla-central/rev/c4fccfb97a4e

== Change summary for alert #28980 (as of Tue, 02 Mar 2021 04:01:26 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
2%	Heap Unclassified		windows10-64-shippable		43,939,396.70 -> 44,985,773.67

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28980

Bogdan Tara[:bogdan_tara | bogdant]

Comment 18

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/354aeecd6463
https://hg.mozilla.org/mozilla-central/rev/e16ad489f8d2

Status: REOPENED → RESOLVED

Closed: 3 years ago → 3 years ago

status-firefox88: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 88 Branch

Ionuț Goldan [:igoldan]

Updated

•

3 years ago

Regressions: 1697455

Daniel Holbert [:dholbert]

Updated

•

3 years ago

Regressions: 1704386

Bug 1694248 - Disable OMTP. r?jrmuizel 3 years ago Matt Woodrow (:mattwoodrow) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1694248 - Don't assert if PBackground has been shut down when we try to create an RDD thread. r?bryce 3 years ago Matt Woodrow (:mattwoodrow) 48 bytes, text/x-phabricator-request		Details \| Review