1694266 - Intermittent comm/mail/test/browser/newmailaccount/browser_newmailaccount.js | Uncaught exception - [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.host]"]

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=330721398&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fbbm9ZuiSMmAqOdrxBceww/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Intermittent Failures Robot]

3 failures in 4327 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform and build breakdown:

• windows10-64-shippable: 1
  • opt: 1
• linux64: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-02-22&endday=2021-02-28&tree=all

Comment 2

[Intermittent Failures Robot]

1 failures in 3683 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• windows7-32-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-03-01&endday=2021-03-07&tree=all

Comment 3

[Intermittent Failures Robot]

2 failures in 3967 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux64: 1
  • opt: 1
• windows7-32-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-03-22&endday=2021-03-28&tree=all

Comment 4

[Intermittent Failures Robot]

3 failures in 3854 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform and build breakdown:

• windows7-32: 2
  • debug: 2
• windows10-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-04-05&endday=2021-04-11&tree=all

Comment 5

[Intermittent Failures Robot]

2 failures in 4255 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux64-shippable: 1
  • opt: 1
• windows7-32: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-04-12&endday=2021-04-18&tree=all

Comment 6

[Intermittent Failures Robot]

1 failures in 3706 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• macosx1015-64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-04-26&endday=2021-05-02&tree=all

Comment 7

[Intermittent Failures Robot]

1 failures in 3279 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• windows10-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-05-03&endday=2021-05-09&tree=all

Comment 8

[Intermittent Failures Robot]

1 failures in 2940 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-07-19&endday=2021-07-25&tree=all

Comment 9

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Error console painted red after just entering an email address in Account Setup and typing password...

I must say that this bug may have the potential to undermine trust in Thunderbird somewhat. On first account setup, right after entering just your email address, pressing Tab into password field and then delaying a bit (feed the cat, walk the dog, you name it), Thunderbird goes in a loop of throwing this error until error console is painted all red :-/

Why would it start doing things with just the email address and no password entered before I choose "Next"?

Comment 10

[Thomas D. (:thomas8)]

STR

91.0.1 (64-Bit), DE, Win10

• Install TB, first account setup (not sure if it happens for every account setup)
• Enter Name and Email address (gmail)
• Press Tab into password field, but do not enter a password
• Move focus elsewhere, and refocus password input

Actual

• Thunderbird throws above error instantly and again every time you focus the password input.
• Error console turns red after just entering my email and focusing password input

Expected

• As a confidence building measure, let's not throw at this stage. We can always toss errors later if we deem that necessary...

Code associated with the error

This is about "LoginAutoComplete", so iiuc, we're allowing password manager to interfere here (as when you fill credentials online and FF will try to save or fill your password). Which makes no sense at all and should be prevented because typically we will not have the password for an account which the user is just adding...

• https://searchfox.org/comm-central/rev/756f4efc3716e09b69a5054189c4947015f702de/mozilla/toolkit/components/passwordmgr/LoginHelper.jsm#661

   getLoginOrigin(uriString, allowJS = false) {`
[snip]
      log.warn("Couldn't parse origin for", uriString, e);

• https://searchfox.org/comm-central/rev/756f4efc3716e09b69a5054189c4947015f702de/mozilla/toolkit/components/passwordmgr/LoginAutoComplete.jsm#536
  let hostname = aElement.ownerDocument.documentURIObject.host;

Comment 11

[Thomas D. (:thomas8)]

Comment on attachment 9237097 [details]
Screenshot 1: Error console painted red after just entering an email address in Account Setup and typing password...

.

Comment 12

[Thomas D. (:thomas8)]

Can we prevent LoginAutoComplete.jsm / password manager from acting on password input when it receives focus?

STR / code starting points in my comment 10.

This is about "LoginAutoComplete", so iiuc, we're allowing password manager to interfere here (as when you fill credentials online and FF will try to fill your password). Which makes no sense at all and should be prevented.

As bug 1724302 mentions, we're saving the password directly.
Which URI are we checking for?

Comment 13

[Alessandro Castellani [:aleca]]

This is a bit out of our control.
We asked for support tot he m-c folks in bug 1724302.

Comment 14

[Thomas D. (:thomas8)]

Comment on attachment 9237097 [details]
Screenshot 1: Error console painted red after just entering an email address in Account Setup and typing password...

Turns out the error is re-generated when focusing the password input, and for every single password character which you type.

Comment 15

[Geoff Lankow (:darktrojan)]

Thomas, this is a bug about an intermittent failure in the CI tests. Why are you hijacking it?

Comment 16

[Intermittent Failures Robot]

1 failures in 2580 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-08-23&endday=2021-08-29&tree=all

Comment 17

[Intermittent Failures Robot]

1 failures in 3084 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-08-30&endday=2021-09-05&tree=all

Comment 18

[Intermittent Failures Robot]

1 failures in 3266 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-09-06&endday=2021-09-12&tree=all

Comment 19

[Intermittent Failures Robot]

1 failures in 3376 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-09-27&endday=2021-10-03&tree=all

Comment 20

[Intermittent Failures Robot]

2 failures in 3626 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux64: 1
  • opt: 1
• linux64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-10-04&endday=2021-10-10&tree=all

Comment 21

[Intermittent Failures Robot]

1 failures in 3259 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2021-11-15&endday=2021-11-21&tree=all

Comment 22

[Intermittent Failures Robot]

2 failures in 3444 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux1804-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-01-17&endday=2022-01-23&tree=all

Comment 23

[Intermittent Failures Robot]

1 failures in 3445 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-01-24&endday=2022-01-30&tree=all

Comment 24

[Intermittent Failures Robot]

1 failures in 3304 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-03-14&endday=2022-03-20&tree=all

Comment 25

[Intermittent Failures Robot]

1 failures in 3323 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-03-28&endday=2022-04-03&tree=all

Comment 26

[Intermittent Failures Robot]

1 failures in 2922 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-04-04&endday=2022-04-10&tree=all

Comment 27

[Intermittent Failures Robot]

1 failures in 3317 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-05-09&endday=2022-05-15&tree=all

Comment 28

[Intermittent Failures Robot]

1 failures in 2917 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-05-30&endday=2022-06-05&tree=all

Comment 29

[Intermittent Failures Robot]

2 failures in 3075 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-06-20&endday=2022-06-26&tree=all

Comment 30

[Intermittent Failures Robot]

1 failures in 3245 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-07-25&endday=2022-07-31&tree=all

Comment 31

[Intermittent Failures Robot]

1 failures in 3057 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-08-01&endday=2022-08-07&tree=all

Comment 32

[Intermittent Failures Robot]

1 failures in 3339 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-08-08&endday=2022-08-14&tree=all

Comment 33

[Intermittent Failures Robot]

3 failures in 2916 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform and build breakdown:

• linux1804-64-shippable-qr: 2
  • opt: 2
• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-08-15&endday=2022-08-21&tree=all

Comment 34

[Intermittent Failures Robot]

2 failures in 3537 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• linux1804-64-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694266&startday=2022-08-29&endday=2022-09-04&tree=all

Comment 35

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1694266 - Avoid exception in browser_newmailaccount.js. r=#thunderbird-reviewers

I think the exception occurs when .host is called on a URI pointing to about:blank. About URIs don't have a host and they throw this exception.

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1f3973f22a4d
Avoid exception in browser_newmailaccount.js. r=mkmelin