Closed
Bug 1694284
Opened 5 years ago
Closed 5 years ago
Use moves to populate webrender::scene_builder_thread::BuiltTransaction
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
There are a bunch of std::mem::replace calls in there which just aren't idiomatic.
|
Assignee | |
Comment 1•5 years ago
|
||
Instead of calling std::mem::replace with dummy values to extract fields from
the TransactionMsg into the BuiltTransaction, it's more Rustic to pass the
former by value and just move its fields out.
SceneBuildingThread::process_transaction seems to contribute almost no self
time to profiles, so the cost of a move instead of passing a reference is
apparently negligible.
|
||
Updated•5 years ago
|
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Pushed by jblandy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c08db48bce8e
Use moves to populate webrender::scene_builder_thread::BuiltTransaction r=gw
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•