1694285 - Proton: Ensure it's clear where arrow panels that open automatically are anchored to

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Dão Gottwald [:dao]]

I haven't checked this in practice, but just by reading bug 1693710's patch it seems that there's going to be a problem for arrow panels that open automatically but can be dismissed for later interaction. E.g. the Update Nightly notification is anchored to the main menu button but there are several buttons next to it it could just as well be anchored to.

To a lesser extent this might also be a problem / look unclear for popups that cannot be dismissed such as the add-on installation doorhanger.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1693710

Comment 2

[Mike Conley (:mconley) (:⚙️)]

The spec calls for the anchor to have a background colour applied when the panel is open. We get some of that already with panels that are anchored to buttons, like the AppMenu button, downloads, protections, identity and control center panel. We don't get it for panels that anchor when those buttons are not activated.

The various permission panel icons, for example, should have this background colour applied. Same with the AppMenu panel when something anchors to it, despite the fact that the AppMenu might itself not be open.

The background colour should match the secondary button hover colour.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hey Neil, how hard do you think it'd be to set an anchoring attribute on the anchor node for a panel when the panel is opened, and remove it when the panel goes away? Is that straight-forward enough to do in the panel.js binding in popupshowing and removing in popuphiding on anchorNode, or are there edge-cases that panel.js wouldn't be able to easily handle?

Comment 4

[Neil Deakin]

For a <panel> that should be ok. You probably want popupshown/popuphidden instead though.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1694285 - Make it more obvious where panels are anchored to with Proton enabled. r?Gijs!,dao!

This seems to take care of the cases that I'm aware of:

• DOM Permission panels
• Panels that anchor to the AppMenu button, like update notification messages, or
  add-on install confirmation messages.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6308384f47a7
Make it more obvious where panels are anchored to with Proton enabled. r=Gijs,desktop-theme-reviewers,dao

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6308384f47a7