1694339 - vCard parsing should handle group prefixes

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

When a contact has an email address or telephone number (or probably other things) that isn't labelled "work" or "home", Google prefixes the item with non-standard labels, then includes the label in a second property:

item1.EMAIL:[e-mail]
item1.X-ABLabel:Unusual

The information in item1.EMAIL is useful to us, because it's an email address. We should use it. The information in item1.X-ABLabel is not, but could be one day.

In this bug I'm proposing to just ignore the "itemX." prefix on any line that exists, so that the information can be treated like a standard vCard.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1694339 - Handle vCard group-prefixed properties when parsing. r?mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e1f7dfb6ba35
Handle vCard group-prefixed properties when parsing. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9204759 [details]
Bug 1694339 - Handle vCard group-prefixed properties when parsing. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): Never worked
User impact if declined: Contacts sync'ed with Google etc. might be missing some key values
Testing completed (on c-c, etc.): Landed two weeks ago
Risk to taking this patch (and alternatives if risky): There is a quite small risk of CardDAV servers complaining that we do something odd, but I've not seen any problems so far and CardDAV is clearly marked experimental in 78

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9204759 [details]
Bug 1694339 - Handle vCard group-prefixed properties when parsing. r?mkmelin

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 87.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/a0755f837929

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9204759 [details]
Bug 1694339 - Handle vCard group-prefixed properties when parsing. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.9.0:
https://hg.mozilla.org/releases/comm-esr78/rev/ad65978402ca