1694380 - geckodriver is not installed at the right place on mac

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jonathan Kew [:jfkthame]]

I ran into problems trying to run a ./mach wpt --headless ... command in my local macOS build, as the harness was failing to find geckodriver.

I made sure to explicitly build geckodriver as per https://firefox-source-docs.mozilla.org/testing/geckodriver/Building.html, which appeared to complete fine, but the wpt command still failed to find it.

It turned out the geckodriver binary was in $OBJDIR/dist/Nightly.app/Contents/Resources/geckodriver, but the test harness was looking for it in $OBJDIR/dist/Nightly.app/Contents/MacOS/geckodriver. The --webdriver-binary option provided a workaround, but ISTM the harness should be looking in the appropriate place by default.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

James, do you know what would be the right place here? I assume it's more what the build job is doing, and so we have to update wptrunner to check the right path here.

Comment 2

[James Graham [:jgraham]]

https://searchfox.org/mozilla-central/source/testing/web-platform/mach_commands.py#130-132 is the code that looks for geckodriver. So it's a bit surprising if it's broken on mac. Not sure if we consider this a mozbuild bug, of if it's the buidl config of geckodriver, or if the wpt mach command needs to handle the difference explictly.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mike, could you (or maybe you know someone else who could) give us a hint where exactly the geckodriver binary should be end-up during the build process? Is there a specific rule for utility binaries?

Comment 4

[Mike Hommey [:glandium]]

It's... not installed at the right place. So this is actually a build system bug.

It should be in Contents/MacOS, but it's in Contents/Resources. The same applies to http3server.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1694380 - Set MOZ_GECKODRIVER rather than ENABLE_GECKODRIVER.

Some places are actually expecting MOZ_GECKODRIVER to be set, rather
than ENABLE_GECKODRIVER, and we more frequently use MOZ_-prefixed
variables, so settle on that.

This fixes browser/app/macbuild/Contents/MacOS-files.txt, which was
expecting MOZ_GECKODRIVER.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1694380 - Add http3server to MacOS files.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d31e801ed59e
Set MOZ_GECKODRIVER rather than ENABLE_GECKODRIVER. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/43fd5b96b18c
Add http3server to MacOS files. r=firefox-build-system-reviewers,andi,mhentges

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d31e801ed59e
https://hg.mozilla.org/mozilla-central/rev/43fd5b96b18c