Date picker disappears after second click
Categories
(Toolkit :: General, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox86 | --- | wontfix |
| firefox87 | --- | wontfix |
| firefox88 | --- | verified |
People
(Reporter: alex.a.pott, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.182 Safari/537.36
Steps to reproduce:
I created a page with the following html:
<body>
<input type="date" />
</body>
And viewed the file in firefox on OS X (catalina).
Actual results:
I click on the date input then the date picker shows. I click somewhere else on the screen and the date picker disappears. I then click again on the date input and the date picker shows but then immediately disappears.
Expected results:
On the second click on the date input the date picker should remain on screen.
|
||
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
I can't reproduce on Linux. alex.a.pott, thanks for the bug report. Is this a recent regression?
|
|
||
Comment 2•3 years ago
|
||
I did forget to set NI to alex. alex does the issue reproduce on older versions of Firefox?
|
Reporter | |
Comment 3•3 years ago
|
||
I have an old mac also on catalina lying around with firefox 82.0.2 - it doesn't happen. After it auto-updated to 85.0.2 it started happening. So yes this is a relatively recent regression.
|
|
||
Comment 4•3 years ago
|
||
Great, thanks for the info. Someone having Mac, please identify what bug caused this issue. Thanks!
|
||
Updated•3 years ago
|
|
||
Comment 5•3 years ago
|
||
Searched for a regression and this is where mozregression led me to between 2020-11-08 and 2020-11-09:
pushlog _url
2021-02-25T10:58:07.055000: DEBUG : Found commit message:
Bug 1339380 - Close datetime picker when focus moves outside of our input element. r=Gijs
|
|
||
Comment 6•3 years ago
|
||
Thank you!
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 7•3 years ago
|
||
On macos re-showing it without using hidden can cause, apparently,
extra popuphidden events. Let's do the right thing and close the popup
properly using hidePopup().
This code wasn't being hit before bug 1339380 because we relied on the
parent side to hide it, which did correctly fire the events.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/468f2f0a7c97 Use hidePopup rather than the hidden attribute to hide datetime picker. r=Gijs
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/2ffa444e9616 Account for panel animations in the test.
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/468f2f0a7c97
https://hg.mozilla.org/mozilla-central/rev/2ffa444e9616
|
||
Comment 11•3 years ago
|
||
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/da87f4cb64ad Port bug 1694413 - Remove hidden attribute from DateTimePickerPanel. rs=bustage-fix
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 13•3 years ago
|
||
Reproduced the issue with Firefox 87.0a1 (20210203214546) on macOS 11.2.3.
The issue is verified fixed with Firefox 88.0b7. The date picker remains opened closed after following STR from comment 0.
Description
•