1694415 - Show dialog titles on Windows/Linux for window-modal dialogs

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Description

[:Gijs (he/him)]

This bit of code: https://searchfox.org/mozilla-central/rev/f47a4b67643b3048ef9a2e2ac0c34edf6d1ebff3/toolkit/components/prompts/src/CommonDialog.jsm#122-134

wants updating so it works for window-modal prompts too. I suspect the simplest thing to do might actually be to check for the common dialog vs. tabmodalprompt element, and for the common dialog document, check if the window's docshell has a chromeEventHandler (ie it's embedded). If it is embedded and not a tabmodalprompt element, we should just show the title, I think.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1694415 - Show dialog titles on Windows/Linux for window-modal dialogs. r?Gijs!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06509c3fe5f4
Show dialog titles on Windows/Linux for window-modal dialogs. r=Gijs

Comment 4

[Atila Butkovits]

Backed out for causing failure at test_prompt.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1f79e2ccd926e5074e968a6ad91fe56b91e83a15

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=DK2lpNPxTP6g6WCU_34DJg.0&revision=06509c3fe5f462b7cc07366ecc2364c0fee97b74&searchStr=windows%2C10%2Cx64%2Copt%2Cmochitests%2Ctest-windows10-64%2Fopt-mochitest-plain-e10s%2C3

Failure log: https://treeherder.mozilla.org/logviewer?job_id=331429627&repo=autoland&lineNumber=7874

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb0ce3e4c2d2
Show dialog titles on Windows/Linux for window-modal dialogs. r=Gijs

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/eb0ce3e4c2d2