1694451 - swgl Crash in [@ blendTextureLinearFallback<T>]

Status: RESOLVED DUPLICATE of bug 1692815

(Core :: Graphics: WebRender, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Nightly Crashes on 4+ devices, oldest reported build ID for Windows 20210219212535, there is also one on macOS: bp-ced23140-655f-4a5f-98be-e26450210219

Crash report: https://crash-stats.mozilla.org/report/index/5a54e403-1802-46a0-8556-232cf0210220

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll blendTextureLinearFallback<1, glsl::sampler2DRect_impl*, NoColor, unsigned int> gfx/wr/swgl/src/swgl_ext.h:326
1 xul.dll blendTextureLinear<1, glsl::sampler2D_impl*, NoColor, unsigned int> gfx/wr/swgl/src/swgl_ext.h:537
2 xul.dll brush_image_ADVANCED_BLEND_ALPHA_PASS_TEXTURE_2D_frag::swgl_drawSpanRGBA8 x86_64-pc-windows-msvc/release/build/swgl-40828f65300b0388/out/brush_image_ALPHA_PASS_TEXTURE_2D.h:910
3 xul.dll static brush_image_ADVANCED_BLEND_ALPHA_PASS_TEXTURE_2D_frag::draw_span_RGBA8 x86_64-pc-windows-msvc/release/build/swgl-40828f65300b0388/out/brush_image_ALPHA_PASS_TEXTURE_2D.h:953
4 xul.dll draw_quad_spans<unsigned int> gfx/wr/swgl/src/gl.cc:4349
5 xul.dll draw_quad gfx/wr/swgl/src/gl.cc:4936
6 xul.dll DrawElementsInstanced gfx/wr/swgl/src/gl.cc:5056
7 xul.dll webrender::renderer::Renderer::draw_instanced_batch<webrender::gpu_types::PrimitiveInstanceData> gfx/wr/webrender/src/renderer/mod.rs:2505
8 xul.dll webrender::renderer::Renderer::draw_alpha_batch_container gfx/wr/webrender/src/renderer/mod.rs:2995
9 xul.dll webrender::renderer::Renderer::draw_frame gfx/wr/webrender/src/renderer/mod.rs:4472

Comment 2

[Lee Salzman [:lsalzman]]

This seems largely quiet now and seems like it was fixed when we cleared out a bunch of other image stability bugs recently. If this signature reoccurs, we should avoid reopening this bug and rather file a new bug about whatever usecase might incidentally cause it, since it would have a different cause from what seems to have caused this.