Closed Bug 1694506 Opened 3 years ago Closed 3 years ago

Sync vendored puppeteer to v8.0.0

Categories

(Remote Protocol :: Agent, task, P2)

Product:
Remote Protocol
Component:
Agent
Type:
task
Points:
8

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: whimboo, Assigned: jdescottes)

Details

(Whiteboard: [bidi-m1-mvp])

Attachments

(3 files)

Bug 1694506 - [puppeteer] Sync vendored puppeteer to v8.0.0
48 bytes, text/x-phabricator-request
Details | Review
Bug 1694506 - [puppeteer] Update puppeteer-expected.json for v8.0.0
48 bytes, text/x-phabricator-request
Details | Review
Bug 1694506 - [puppeteer] chore: skip non-standard cookie asserts on Firefox (sync #6994)
48 bytes, text/x-phabricator-request
Details | Review

Version 7.1.0 is the most recent release:
https://github.com/puppeteer/puppeteer/releases/tag/v7.1.0

Even Puppeteer doesn't contain BiDi code yet, we should keep up-to-date. As longer as we are waiting with a sync, as more complex it will be.

A new major release of Puppeteer just appeared:
https://github.com/puppeteer/puppeteer/releases/tag/v8.0.0

Summary: Sync vendored puppeteer to v7.1.0 → Sync vendored puppeteer to v8.0.0
Points: --- → 8
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Slightly blocked on try job outage right now, but a quick summary:

(In reply to Julian Descottes [:jdescottes] from comment #2)

Would you mind filing an upstream issue? I would like to know what can be done here to keep the cross-browser compatibility for cookie tests. It would be bad if we have to mark them as disabled.

  • a few new tests to add to the puppeteer-expected.json

Would be interested in the numbers of how many pass/fail now. So lets hope try will be back soon.

Thanks Julian!

Would you mind filing an upstream issue?

Filed https://github.com/puppeteer/puppeteer/issues/6976
I assume it should be doable to only check the non-standard properties when running in Chrome?

Would be interested in the numbers of how many pass/fail now

Here's a quick breakdown:

New tests:

  • PASS: Page Page.waitForRequest should work with async predicate (page.spec.ts)
  • PASS: JSHandle JSHandle.jsonValue works with jsonValues that are not objects (jshandle.spec.ts)
  • PASS: JSHandle JSHandle.jsonValue works with jsonValues that are primitives (jshandle.spec.ts)
  • FAIL: Page Page.emulateNetworkConditions should change navigator.connection.effectiveType (page.spec.ts)
  • FAIL: Launcher specs Puppeteer Puppeteer.connect should be able to reconnect (launcher.spec.ts)

The existing TIMEOUT test Page Page.Events.Popup should work with clicking target=_blank (page.spec.ts) was split in 2:

  • TIMEOUT: Page Page.Events.Popup should work with clicking target=_blank and without rel=opener (page.spec.ts)
  • TIMEOUT: Page Page.Events.Popup should work with clicking target=_blank and with rel=opener (page.spec.ts)

The existing FAIL test Screenshots Page.screenshot should clip elements to the viewport (screenshot.spec.ts) was changed and is now passing (we didn't clip to the viewport, and puppeteer doesn't expect that anymore):

  • PASS: Screenshots Page.screenshot should get screenshot bigger than the viewport (screenshot.spec.ts)

So overall, just 2 new FAIL so far. One for emulateNetworkConditions, which is expected. The second one is more interesting Puppeteer.connect should be able to reconnect, not sure yet why this fails for Firefox.

You can check the current sync diff at https://hg.mozilla.org/try/rev/5d03c9221e0998f1cbbd1e5be7b927fc35d0313d

(In reply to Julian Descottes [:jdescottes] from comment #4)

So overall, just 2 new FAIL so far. One for emulateNetworkConditions, which is expected. The second one is more interesting Puppeteer.connect should be able to reconnect, not sure yet why this fails for Firefox.

Sounds ok. The reconnect test is new? I can remember that I have also seen problems when running the chrome-remote-interface unit tests. But no idea why it's failing.

Generated by running ./mach remote vendor-puppeteer and replacing itFailsFirefox to it etc...

Depends on D108099

Summary of changes.
New tests:

  • PASS: Page Page.waitForRequest should work with async predicate (page.spec.ts)
  • PASS: JSHandle JSHandle.jsonValue works with jsonValues that are not objects (jshandle.spec.ts)
  • PASS: JSHandle JSHandle.jsonValue works with jsonValues that are primitives (jshandle.spec.ts)
  • FAIL: Page Page.emulateNetworkConditions should change navigator.connection.effectiveType (page.spec.ts)
  • FAIL: Launcher specs Puppeteer Puppeteer.connect should be able to reconnect (launcher.spec.ts)

The existing TIMEOUT test "Page Page.Events.Popup should work with clicking target=_blank (page.spec.ts)" was split in 2:

  • TIMEOUT: Page Page.Events.Popup should work with clicking target=_blank and without rel=opener (page.spec.ts)
  • TIMEOUT: Page Page.Events.Popup should work with clicking target=_blank and with rel=opener (page.spec.ts)

The existing FAIL test "Screenshots Page.screenshot should clip elements to the viewport (screenshot.spec.ts)" was changed and is now passing (we didn't clip to the viewport, and puppeteer doesn't expect that anymore):

  • PASS: Screenshots Page.screenshot should get screenshot bigger than the viewport (screenshot.spec.ts)

The existing SKIP test "Launcher specs Puppeteer Puppeteer.launch should be able to launch Firefox (launcher.spec.ts)" is now running with itFailsWindows instead of itOnlyRegularInstall. It used to be flagged as SKIP, but it is now failing because we attempt to run it.

  • FAIL: Launcher specs Puppeteer Puppeteer.launch should be able to launch Firefox (launcher.spec.ts)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c91e827cf38a
[puppeteer] Sync vendored puppeteer to v8.0.0 r=remote-protocol-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/6a73f4984952
[puppeteer] chore: skip non-standard cookie asserts on Firefox (sync #6994) r=remote-protocol-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/d3089529400c
[puppeteer] Update puppeteer-expected.json for v8.0.0 r=remote-protocol-reviewers,whimboo

https://hg.mozilla.org/mozilla-central/rev/c91e827cf38a
https://hg.mozilla.org/mozilla-central/rev/6a73f4984952
https://hg.mozilla.org/mozilla-central/rev/d3089529400c

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Blocks: 1707588
No longer blocks: 1707588
Priority: P3 → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: