1694507 - Update messaging in "restart with add-ons disabled" / "safe mode" dialog

Status: RESOLVED FIXED

(Toolkit :: General, enhancement, P2)

Description

[:Gijs (he/him)]

Title should be:

Restart {Brand name} in Troubleshoot Mode?

Message:

Your add-ons and custom settings will be temporarily disabled.

Buttons should be "Restart" and "Cancel".

On about:support, the labeling for this option should use "Diagnose issues" as the header, and "Troubleshoot Mode..." as the button label.

Comment 1

[:Gijs (he/him)]

To be clear, this is about the dialog that shows up because of the code at https://searchfox.org/mozilla-central/rev/a6db3bd67367aa9ddd9505690cab09b47e65a762/browser/components/BrowserGlue.jsm#1418-1425 , not safeMode.xhtml, which is bug 1694509

Comment 2

[:Gijs (he/him)]

Update priority to reflect proton priorities.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1694507 - Update messaging in "restart with add-ons disabled" / "safe mode" dialog

Comment 4

[Francesco Lodolo [:flod]]

(In reply to :Gijs (he/him) from comment #0)

Your add-ons and custom settings will be temporarily disabled.

Could you point me to the reference/source for this dialog? I looked around but I failed to find it.

My understanding was that add-on is a term we want to avoid moving forward.

Comment 5

[:Gijs (he/him)]

(In reply to Francesco Lodolo [:flod] from comment #4)

(In reply to :Gijs (he/him) from comment #0)

Your add-ons and custom settings will be temporarily disabled.

Could you point me to the reference/source for this dialog? I looked around but I failed to find it.

My understanding was that add-on is a term we want to avoid moving forward.

https://docs.google.com/presentation/d/1YtPJEvUigRybLkuoALYvl63MVg_a6-Db4orDzNdEkIk/edit?ts=601cb14a#slide=id.gbcd044429d_0_73 slide 37 (behind LDAP, I'm afraid). I'll check with Meridel re: add-on.

Comment 6

[Meridel [:meridel]]

I just tested this and it looks like your themes are NOT disabled. Gijs, can you please confirm this? If this is the case, we can update the modal copy to say "Your extensions and custom settings..."

Comment 7

[:Gijs (he/him)]

(In reply to Meridel from comment #6)

I just tested this and it looks like your themes are NOT disabled.

It does disable themes if they were installed from somewhere else (you can use the suggestions at the bottom of the themes section in about:addons to test). It doesn't disable built-in themes (default/light/dark/alpenglow).

Gijs, can you please confirm this? If this is the case, we can update the modal copy to say "Your extensions and custom settings..."

So I'm not sure what you want to do. I think this dialog probably shouldn't be trying to describe the precise theme behaviour in detail. I'm not even sure how intentional the current theming behaviour is, but I'd like to not change it here right now if at all possible. Thoughts?

Comment 8

[Meridel [:meridel]]

Ideally, if this didn't introduce scope, we'd revise the modal string to be: "Your extensions, themes, and custom settings will be temporarily disabled."

If it is re-work and time to make that string change now, I think it is fine to leave it as: "Your add-ons and custom settings will be temporarily disabled."

I apologize for not catching this earlier in the copy development process. We are trying to use 'extensions and themes' and avoid 'add-ons' but the fact is that our add-ons website, and other places in product, still uses the term 'add-on' and so this will be a process to make the change. We don't have to catch it all now.

Comment 9

[:Gijs (he/him)]

We haven't landed the patch, so we'll update it. Thanks!

Comment 10

[Meridel [:meridel]]

Great! Thanks, Gijs. I updated both Figma and the content design deck so documentation is accurate and up-to-date.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3eb3b696d9a1
Update messaging in "restart with add-ons disabled" / "safe mode" dialog r=jaws,flod

Comment 12

[Meridel [:meridel]]

Attachment: Troubleshoot Mode - Brand name instances.png

Both troubleshoot modals should use {Brand name}, and not {brand full name}. Documentation has been updated and Flod is landing a patch.

Comment 13

[Francesco Lodolo [:flod]]

Bug 1697174 fixes the message landed in bug 1694509 with brand-full-name. This one is already good as is.

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3eb3b696d9a1

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ef9039fe57b8
Port bug 1694507 - Update messaging in "restart with add-ons disabled" / "safe mode" dialog. rs=bustage-fix