1694548 - Break on > Attribute Modification doesn't work for style attribute mutations or Shadow DOM

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: Self-descriptive testcase

What were you doing?

Trying to debug something by breaking when its style attribute changed.

What happened?

Didn't break.

What should have happened?

Break.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Ah, hmm... This works with dom.mutation-events.cssom.disabled=false. Does devtools use mutation events for this? :/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

So it seems... And that's problematic, because those events don't fire in e.g. shadow trees. We need to find a way for this not to depend on mutation listeners...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case for Shadow DOM.

Yep, also broken on Shadow DOM...

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1694548 - Rename Document.dontWarnAboutMutationEventsAndAllowSlowDOMMutations and other misc cleanup in Document. r=smaug

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1694548 - Move devtools breakpoints out of mutation events. r=smaug

Use internal events which get fired for CSSOM changes, and in Shadow
DOM. This will also allow us to remove mutation events in the future.

Depends on D106273

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Honza, do you know where to best add a test for this? I only saw devtools/client/inspector/markup/test/browser_markup_dom_mutation_breakpoints.js...

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)

Honza, do you know where to best add a test for this? I only saw devtools/client/inspector/markup/test/browser_markup_dom_mutation_breakpoints.js...

Replying in Phab
https://phabricator.services.mozilla.com/D106274

Honza

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3faa9b27e4a5
Rename Document.dontWarnAboutMutationEventsAndAllowSlowDOMMutations and other misc cleanup in Document. r=smaug
https://hg.mozilla.org/integration/autoland/rev/c87745c8f28b
Move devtools breakpoints out of mutation events. r=smaug,jdescottes

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53407f6a9c27
Backed out 2 changesets on suspicion of causing dt crashes in nsINode::LastRelease.

Comment 11

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1694548) on suspicion of causing dt crashes in nsINode::LastRelease.

Backout link: https://hg.mozilla.org/integration/autoland/rev/53407f6a9c27425316b2fa3ec12c0ef8d5762b80

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=d683ade21debe1d108e7ad85d62e9087d67cefe3&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-fis-e10s&test_paths=devtools%2Fclient%2Fdebugger%2Ftest%2Fmochitest&tochange=e831edff89a252ec2eb1927fd51745a90952906b

Failure log: https://treeherder.mozilla.org/logviewer?job_id=331767351&repo=autoland&lineNumber=25387

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31483e46e546
Rename Document.dontWarnAboutMutationEventsAndAllowSlowDOMMutations and other misc cleanup in Document. r=smaug
https://hg.mozilla.org/integration/autoland/rev/8c202f711dbd
Move devtools breakpoints out of mutation events. r=smaug,jdescottes

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/31483e46e546
https://hg.mozilla.org/mozilla-central/rev/8c202f711dbd

Comment 14

[Julian Descottes [:jdescottes]]

Thanks a lot for figuring this out and fixing it without regressing anything in the current DOM breakpoints Emilio!