1694624 - Make the CrashManager handle a missing crash directory gracefully

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Gabriele Svelto [:gsvelto]]

Right now if CrashManager._getStore() fails it just returns NULL. The code using it blindly accesses the returned object so we end up bubbling up an error when it happens (usually during shutdown). This is probably not the right thing to do and we should adjust the code to gracefully handle this scenario (possibly by quietly aborting the current operation given there's nothing that can be done if the store is inaccessible).

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Don't think this needs to be S2.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1694624 - Handle failures to access the crash store silently r=afranchuk

Comment 3

[Gabriele Svelto [:gsvelto]]

Try run is here, fingers crossed: https://treeherder.mozilla.org/jobs?repo=try&revision=d3f4bff62a33ea6a16224c8c4f1f2780e77fc814

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hi Alex, any chance you could get to the review? This change would help address several test failures in CI. Thanks.

Comment 5

[Alex Franchuk [:afranchuk]]

Sorry, fell off my radar. Reviewed!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b65ea4964cf
Handle failures to access the crash store silently r=afranchuk

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4b65ea4964cf