Closed Bug 1694661 Opened 4 years ago Closed 4 years ago

Update repeat prompt and tab switch checkbox labels for content prompts

Categories

(Firefox :: Tabbed Browser, enhancement, P2)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-modals] [priority:2a])

Attachments

(2 files)

We show checkboxes in website alert/prompt/confirm dialog boxes in 2 cases:

  1. if they have repeatedly prompted. This is used from nsGlobalWindowOuter.cpp (twice, there's some duplication). We should update the text to "Don’t allow {domain} to prompt you again". (no trailing dot/period)
  2. if they appeared on a background tab, to allow the user to give permission for these modals to switch tabs. This is done from PromptParent.jsm and browser.js. We should update the text to "Allow notifications like this from {domain} to take you to their tab" (no trailing dot/period)

Update priority to reflect proton priorities.

Priority: P3 → P2
Attachment #9207627 - Attachment description: Bug 1694661 - Update repeat prompt and tab switch checkbox labels for content prompts. → Bug 1694661 - Update tab switch checkbox labels for content prompts.
Assignee: nobody → zbraniecki
Status: NEW → ASSIGNED

Zibi, do you need help with updating the second patch here?

Flags: needinfo?(zbraniecki)
Whiteboard: [proton-modals] → [proton-modals] [priority:2a]

I'm going to try to get this over the line per discussion with Zibi.

Assignee: zbraniecki → gijskruitbosch+bugs
Flags: needinfo?(zbraniecki)
Attachment #9207632 - Attachment description: Bug 1694661 - Update repeat prompt label for content prompts. → WIP: Bug 1694661 - Update repeat prompt label for content prompts.
Attachment #9207632 - Attachment description: WIP: Bug 1694661 - Update repeat prompt label for content prompts. → Bug 1694661 - Update repeat prompt label for content prompts, r?nika!,flod!
Attachment #9207627 - Attachment description: Bug 1694661 - Update tab switch checkbox labels for content prompts. → Bug 1694661 - Update tab switch checkbox labels for content prompts, r?jaws,Gijs
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1489f5116eef Update tab switch checkbox labels for content prompts, r=Gijs,fluent-reviewers,jaws
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ecbfdc6b3929 Update repeat prompt label for content prompts, r=nika,flod
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Blocks: 1703711

Verified in latest nightly build 90.0a1 (2021-05-13) (64-bit) and beta build 89.0b11 (64-bit)
checkboxes in website alert/prompt/confirm dialog are properly displayed:

  • if repeatedly prompted, the text reads "Don’t allow this site/ domain to prompt you again"
  • if they appeared on a background tab, the text reads "Allow notifications like this from {domain} to take you to their tab"
    Updating status accordingly.
    Best regards,
    Clara
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: