Closed Bug 1694671 Opened 1 year ago Closed 10 months ago

Crash in [@ rayon_core::job::{{impl}}::execute<T>]


(Core :: Layout, defect)

Windows 7



92 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- fixed
firefox86 + wontfix
firefox87 + wontfix
firefox88 + wontfix
firefox89 --- wontfix
firefox92 --- fixed


(Reporter: aryx, Assigned: emilio)



(Keywords: crash, topcrash)

Crash Data


(1 file)

[Tracking Requested - why for this release]: Frequent crash

50+ crashes in a single day on release, all on Windows 7 with Firefox 32-bit executable. The signature was already active for previous releases but often <50 crashes for the whole cycle and those crashes also included amd64.

Emilio, can you investigated what's causing these crashes?

Crash report:

MOZ_CRASH Reason: called `Option::unwrap()` on a `None` value

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/
2 xul.dll core::ops::function::Fn::call<fn ../e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/core/src/ops/
3 xul.dll std::panicking::rust_panic_with_hook ../e1884a8e3c3e813aada8254edfa120e85bf5ffca//library/std/src/
4 xul.dll std::panicking::begin_panic_handler::{{closure}} ../e1884a8e3c3e813aada8254edfa120e85bf5ffca//library/std/src/
5 xul.dll std::sys_common::backtrace::__rust_end_short_backtrace<closure-0, !> ../e1884a8e3c3e813aada8254edfa120e85bf5ffca//library/std/src/sys_common/
6 xul.dll std::panicking::begin_panic_handler ../e1884a8e3c3e813aada8254edfa120e85bf5ffca//library/std/src/
7 xul.dll core::panicking::panic_fmt ../e1884a8e3c3e813aada8254edfa120e85bf5ffca//library/core/src/
8 xul.dll core::panicking::panic ../e1884a8e3c3e813aada8254edfa120e85bf5ffca//library/core/src/
9 xul.dll rayon_core::job::{{impl}}::execute<closure-0> third_party/rust/rayon-core/src/
Flags: needinfo?(emilio)
Severity: -- → S2

Rayon was updated in 86 (bug 1683294). Probably a rayon regression?

Flags: needinfo?(emilio)
See Also: → 1683294
Depends on: 1697842

This should help us isolate what rayon changes could've caused this
stability issue on 32-bit windows.

Automatically generated with:

$ cargo update -p rayon --precise 1.4.0 && cargo update -p rayon-core --precise 1.8.0 && ./mach vendor rust

Assignee: nobody → emilio
Pushed by
Downgrade rayon-core to 1.8.0, rayon to 1.4.0. r=jrmuizel
Attachment #9208433 - Attachment description: Bug 1694671 - Downgrade rayon-core to 1.8.0, rayon to 1.4.0. r=nical,jrmuizel → Bug 1694671 - Downgrade rayon-core to 1.8.1, rayon to 1.4.1. r=nical,jrmuizel
Flags: needinfo?(emilio)
Pushed by
Downgrade rayon-core to 1.8.1, rayon to 1.4.1. r=jrmuizel
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

We still don't know if/how this will affect the crash rate.

Flags: needinfo?(emilio)
Resolution: FIXED → ---

Is there anything else we can do here?

Flags: needinfo?(emilio)

We can keep bisecting / downgrading I guess. Other than that, we could really use the help of somebody with windows knowledge to see what might be going on, but that might be hard.

Trying to build a win32 rayon stress test and see whether we can reproduce the crash is another thing to do, but it will probably take a bit of time. I can try though.

I believe bug 1716028 has helped quite a lot here, crash rate since 92 seems way down.

Flags: needinfo?(emilio)

I think I'll call this fixed for now. We can dig into it if it shows up again.

Closed: 1 year ago10 months ago
Resolution: --- → FIXED
Target Milestone: 88 Branch → 92 Branch
You need to log in before you can comment on or make changes to this bug.