Closed
Bug 1694685
Opened 3 years ago
Closed 3 years ago
Remove JSPROP_INTERNAL_USE_BIT
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(5 files)
It's used to distinguish a JSPropertySpec storing an accessor vs plain value, but we can do that more easily by adding a bool.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
There are multiple (nested) unions so the size isn't obvious.
Adding a sanity check helps catch regressions.
|
|
Assignee | |
Comment 3•3 years ago
|
||
Use a custom enum class instead of JSValueType so it's more obvious what the
supported types are.
Depends on D106406
|
||
Updated•3 years ago
|
Attachment #9205119 -
Attachment description: Bug 1694685 - Replace JSPROP_INTERNAL_USE_BIT with an isAccessor_ flag. → Bug 1694685 part 3 - Replace JSPROP_INTERNAL_USE_BIT with an isAccessor_ flag. r?tcampbell
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D106283
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D106408
|
|
||
Updated•3 years ago
|
Attachment #9205336 -
Attachment description: Bug 1694685 part 5 - Rename JS_CHECK_ACCESSOR_FLAGS macro with a C++ template. r?tcampbell! → Bug 1694685 part 5 - Replace JS_CHECK_ACCESSOR_FLAGS macro with a C++ template. r?tcampbell!
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f8f7adab1fc part 1 - Add static_assert for JSPropertySpec size. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/f5e059a234f2 part 2 - Use enum class for ValueWrapper::type. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/69bd0269f12a part 3 - Replace JSPROP_INTERNAL_USE_BIT with an isAccessor_ flag. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/8e3a58acbdca part 4 - Rename JSPropertySpec flags_ to attributes_. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/8028d4ceaf09 part 5 - Replace JS_CHECK_ACCESSOR_FLAGS macro with a C++ template. r=tcampbell
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6f8f7adab1fc
https://hg.mozilla.org/mozilla-central/rev/f5e059a234f2
https://hg.mozilla.org/mozilla-central/rev/69bd0269f12a
https://hg.mozilla.org/mozilla-central/rev/8e3a58acbdca
https://hg.mozilla.org/mozilla-central/rev/8028d4ceaf09
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•