1694731 - Intermittent browser/base/content/test/siteIdentity/browser_identityPopup_focus.js | learn more option for custom roots is focused - Got [object XULElement], expected [object XULTextElement]

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=331040772&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/UDgTsn5uQgmRfNGdLQolpA/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-02-24T17:17:06.896Z] 17:17:06     INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identityPopup_focus.js | undefined assertion name - 
[task 2021-02-24T17:17:06.896Z] 17:17:06     INFO - Buffered messages finished
[task 2021-02-24T17:17:06.897Z] 17:17:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_identityPopup_focus.js | learn more option for custom roots is focused - Got [object XULElement], expected [object XULTextElement]
[task 2021-02-24T17:17:06.898Z] 17:17:06     INFO - Stack trace:
[task 2021-02-24T17:17:06.899Z] 17:17:06     INFO - chrome://mochikit/content/browser-test.js:test_is:1359
[task 2021-02-24T17:17:06.899Z] 17:17:06     INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_identityPopup_focus.js:testSiteSecurityTabOrder/<:87
[task 2021-02-24T17:17:06.900Z] 17:17:06     INFO - GECKO(1830) | [Child 2007: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fc9cc346c00 == 1 [pid = 2007] [id = 36] [url = https://example.com/]
[task 2021-02-24T17:17:06.901Z] 17:17:06     INFO - GECKO(1830) | [Child 2007: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x7fc9ccdaec00) [pid = 2007] [serial = 118] [outer = (nil)] [url = http://example.com/]
[task 2021-02-24T17:17:06.901Z] 17:17:06     INFO - GECKO(1830) | [Child 2007: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x7fc9cc341000) [pid = 2007] [serial = 113] [outer = (nil)] [url = about:blank]
[task 2021-02-24T17:17:06.902Z] 17:17:06     INFO - GECKO(1830) | [Child 2007: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0x7fc9cc5a1c00) [pid = 2007] [serial = 115] [outer = (nil)] [url = https://example.com/]
[task 2021-02-24T17:17:06.903Z] 17:17:06     INFO - GECKO(1830) | [Child 2007: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x7fc9cc593c00) [pid = 2007] [serial = 114] [outer = (nil)] [url = https://example.com/]
[task 2021-02-24T17:17:06.903Z] 17:17:06     INFO - GECKO(1830) | [Child 2007: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x7fc9cc346000) [pid = 2007] [serial = 117] [outer = (nil)] [url = about:blank]
[task 2021-02-24T17:17:06.904Z] 17:17:06     INFO - GECKO(1830) | [Child 2007: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7fc9ccdb2000) [pid = 2007] [serial = 119] [outer = (nil)] [url = https://example.com/]
[task 2021-02-24T17:17:06.905Z] 17:17:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-02-24T17:17:06.907Z] 17:17:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_identityPopup_focus.js | more info button is focused - Got [object XULElement], expected [object XULElement]
[task 2021-02-24T17:17:06.908Z] 17:17:06     INFO - Stack trace:
[task 2021-02-24T17:17:06.908Z] 17:17:06     INFO - chrome://mochikit/content/browser-test.js:test_is:1359
[task 2021-02-24T17:17:06.909Z] 17:17:06     INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_identityPopup_focus.js:testSiteSecurityTabOrder/<:101
[task 2021-02-24T17:17:06.909Z] 17:17:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-02-24T17:17:06.910Z] 17:17:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_identityPopup_focus.js | back button is focused - Got [object XULTextElement], expected [object XULElement]```

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1590884 landed shortly before this started. Tim, could you take a look?

Comment 2

[Tim Nguyen :ntim]

Test gets confused here: https://searchfox.org/mozilla-central/rev/df23c6e58c6be1eb8399e475878f73d4867bef87/browser/base/content/test/siteIdentity/browser_identityPopup_focus.js#82-118

Labels are involved in various ways in these parts, but accesskeys don't look directly involved here.

There are a few subtleties that changed about labels (e.g. frame construction, now properly updating accesskeys on value/control attribute changes, initializing accesskey at a different time). It's hard to tell tbh.

Emilio, do you have a rough idea what's happening? Feel free to redirect to pbz/johannh if you think this is rather an issue with the test.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

So a XULTextElement is getting focused, which is a label or a description. Can you check that we're ending up with the same frame tree / layout? That's the most obvious plausible reason for that (if the element is scrollable it is tab focusable).

Comment 4

[Tim Nguyen :ntim]

The first element that fails to focus is a <label> in this case, so previously nsXULLabelFrame, but now display: inline-block. So the frame tree definitely changed here.

I can check if anything changed visually, but that's unlikely.

I'm guessing this is intermittent because subviews expand when you open them or something

Comment 5

[Emilio Cobos Álvarez (:emilio)]

I mean, did it effectively change? nsXULLabelFrame was just an nsBlockFrame in disguise.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Does that label have overflow: hidden / overflow: auto or such? I guess before we weren't creating an scrollframe at all, and now we could.

Comment 7

[Tim Nguyen :ntim]

This should be fixed by bug 1694936.

Comment 8

[Intermittent Failures Robot]

4 failures in 4327 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64: 4
  • debug: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694731&startday=2021-02-22&endday=2021-02-28&tree=all