Python triple-quoted strings aren't syntax-highlighted like single-quoted strings
Categories
(Conduit :: Phabricator, defect, P5)
Tracking
(Not tracked)
People
(Reporter: Waldo, Unassigned)
Details
(Keywords: conduit-triaged, conduit-upstream)
A rev like https://phabricator.services.mozilla.com/D101398 that contains significant amounts of code, interspersed with significant numbers of large triple-quoted sections of C++ text, is noticeably more difficult to read and understand when the triple-quoted sections aren't syntax-highlighted as strings.
It turns out that Phabricator etc. fully recognize triple-quoted strings. It's just that the CSS style rules don't actually set the text color consistent with other strings' contents. And, simply changing one rule to set a color other than black, will fix this:
.remarkup-code .sd,
.remarkup-code .sh {
color:#766510;
}
instead of the #000 currently used.
Dunno for sure where the Phabricator integration code lives, plus I now have a workaround for efficiently reviewing that patch (and others in the future), so I'm going to kick this over to you and let you deal with the fix.
Updated•5 years ago
|
Description
•