Open
Bug 1695149
Opened 5 years ago
Updated 3 years ago
Investigate replacing wrapRender with componentDidThrow
Categories
(DevTools :: Shared Components, task, P3)
DevTools
Shared Components
Tracking
(Not tracked)
NEW
People
(Reporter: nchevobbe, Unassigned, Mentored)
Details
wrapRender (See devtools/client/shared/components/reps/reps/rep-utils.js#311-335 ) was added to prevent crashing a panel when a component was throwing an exception.
In React 16 there's a new lifecycle function which does exactly this: componentDidThrow.
We need to check how we can use this at the rep level since they're only functions.
We'll have to check that this does not harm performance in the console.
|
||
Comment 1•3 years ago
|
||
Redirect a needinfo that is pending on an inactive user to the triage owner.
:Honza, since the bug doesn't have a severity set, could you please set the severity or close the bug?
For more information, please visit auto_nag documentation.
Flags: needinfo?(useruser) → needinfo?(odvarko)
|
||
Updated•3 years ago
|
Severity: -- → S3
Flags: needinfo?(odvarko)
Priority: -- → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•