Closed Bug 1695212 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27801 - [Reland]: Repaint when bgcolor animation is triggered

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27801 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27801
Details from upstream follow.

b'Xida Chen <xidachen@chromium.org>' wrote:

[Reland]: Repaint when bgcolor animation is triggered

This CL is the reland of:
https://chromium-review.googlesource.com/c/chromium/src/+/2698847

The above CL was reverted because the layout test added was flaky.
In this CL, PS#1 is the reverted CL, and we need to make sure
that the test is no longer flaky.

It turns out that it was the non-virtual version that was flaky,
and the reason is that double raf doesn't seem to be enough to
make the animation jump into the mid-point. I have tested
locally with 500 runs, and the failure rate is ~99%, Oh, that's
bad...

The solution is very simple, which is to use triple raf instead
of double raf, I have ran both the virtual and non-virtual version
of the test, each one for 500 times locally, and there is no
failure at all.

Bug: 1177320
Change-Id: I95f576994a5d67bf8319b5b1f33e8e6fca6d4bb8

Reviewed-on: https://chromium-review.googlesource.com/2716060
WPT-Export-Revision: 22c7f0c04b11c22e2b4dee08aee34782a0f7fbbe

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2233af004c5
[wpt PR 27801] - [Reland]: Repaint when bgcolor animation is triggered, a=testonly
https://hg.mozilla.org/integration/autoland/rev/22c5ba9adf0b
[wpt PR 27801] - Update wpt metadata, a=testonly
Regressions: 1698486

https://hg.mozilla.org/mozilla-central/rev/b2233af004c5
https://hg.mozilla.org/mozilla-central/rev/22c5ba9adf0b

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.