1695216 - XMLHttpRequest should reset response upon receiving a bad chunk

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Anne (:annevk)]

See https://github.com/whatwg/xhr/pull/315 and https://github.com/web-platform-tests/wpt/pull/27778. With chunked encoding Firefox does not reset responseText and such upon receiving garbage. Presumably this also applies to a bad chunk from a ReadableStream object, but I didn't explicitly test that scenario.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Anne, my interpretation of this is that the spec has evolved to account for a defect, and you've filed this bug to track the fact that our implementation should catch up. P2 based on that - but let me know if my interpretation is wrong.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

(and the defect in question does not seem to me to be a P1 to fix)

Comment 3

[Anne (:annevk)]

It doesn't seem particularly high priority, but good to fix to align our behavior with the spec and other browsers.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1695216 - XMLHttpRequest should reset response upon network errors. r=annevk!,#necko!

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1695216 - XMLHttpRequest should reset response upon receiving a bad chunk. r=annevk!,#necko!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/914436169022
XMLHttpRequest should reset response upon receiving a bad chunk. r=annevk,necko-reviewers

Comment 7

[Marian-Vasile Laza]

Backed out changeset 914436169022 (Bug 1695216) for causing build bustages.
Backout link
Push with failures - B
Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6819fdea3a5
XMLHttpRequest should reset response upon network errors. r=annevk,necko-reviewers

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea893f7838e1
Backed out changeset c6819fdea3a5 for causing XMLHttpRequestWorker related crashes. CLOSED TREE

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for causing several failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=c6819fdea3a5816502053c7c977ca0bf554d5af9&selectedTaskRun=T1QFdBINQpSnhn3q-D96sg.0

Failure logs:

• crashes: https://treeherder.mozilla.org/logviewer?job_id=352563633&repo=autoland
• xpc failures: https://treeherder.mozilla.org/logviewer?job_id=352560965&repo=autoland
• mochitest plain failures: https://treeherder.mozilla.org/logviewer?job_id=352560932&repo=autoland
• assertion failures: https://treeherder.mozilla.org/logviewer?job_id=352565164&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/ea893f7838e1f46575b355335192e2fa0a3a1e8a

Comment 11

[(inactive) Nihanth Subramanya [:nhnt11]]

Recalibrating my priorities. I might pick this back up. The patch is pretty much there, but need to iron out the test failures.

Comment 12

[Thomas Wisniewski [:twisniewski]]

https://treeherder.mozilla.org/jobs?repo=try&revision=e50ef37c7502f1c398effb93eaaabaf20302f2b6&selectedTaskRun=MGhK8BteSjCDIeSWEeKWwA.0

Comment 13

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1695216 - Follow the XMLHttpRequest spec more closely for network and other errors; r?kershaw

• clear the response on network failure (bad chunks, etc).
• throw the expected error for abort/timeout/error for sync XHR failures.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e7d1a045e6c
Follow the XMLHttpRequest spec more closely for network and other errors; r=kershaw,sunil

Comment 15

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9e7d1a045e6c