1695243 - Check if we can get rid of "{}" when importing the addDebuggerToGlobal in Runtime.jsm

Status: RESOLVED FIXED

(Remote Protocol :: CDP, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Follow-up from https://phabricator.services.mozilla.com/D106602#inline-595792. Here what Julian wrote:

I am curious about this one. Do we really need to pass this object here?
I think this is the only call site in mozilla-central where we import addDebuggerToGlobal from jsdebugger.jsm this way.
https://searchfox.org/mozilla-central/search?path=&q=%7B%20addDebuggerToGlobal%20%7D%20%3D%20ChromeUtils.import

It doesn't seem the item was discussed at all during the initial review (https://phabricator.services.mozilla.com/D27525), so maybe it's just unnecessary? We could try to get rid of it in a followup.

https://searchfox.org/mozilla-central/source/remote/cdp/domains/content/Runtime.jsm#9-12,25-26

Alexandre, can you remember why this was necessary?

Comment 1

[Julian Descottes [:jdescottes]]

To be clear, I was only referring to the additional {} passed to ChromeUtils.import, not the whole import. Basically the question is, can we change:

const { addDebuggerToGlobal } = ChromeUtils.import(
  "resource://gre/modules/jsdebugger.jsm",
  {}
);

to

const { addDebuggerToGlobal } = ChromeUtils.import(
  "resource://gre/modules/jsdebugger.jsm"
);

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh sorry. Thanks for the clarification.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1695243 - [remote] Remove 3rd argument when importing "addDebuggerToGlobal".

Comment 4

[Alexandre Poirot [:ochameau]]

That should be fine, it looks like pure legacy inherited from Components.utils.import and was used to avoid polluting the global scope.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f6ce1f03e84
[remote] Remove 3rd argument when importing "addDebuggerToGlobal". r=remote-protocol-reviewers,jdescottes

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1f6ce1f03e84