Closed Bug 1695283 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27805 - Remove unused variable and move reset session to a function

Categories

(Testing :: geckodriver, task, P4)

Product:
Testing
Component:
geckodriver
Type:
task

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27805 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27805
Details from upstream follow.

b'Shengfa Lin <shengfa@google.com>' wrote:

Remove unused variable and move reset session to a function

Per https://github.com/web-platform-tests/wpt/pull/27734/files/1abbaacbe6091d252040e6a5405e4ee90b3a64f8#r583470855,
move duplicate code into its own function and removed unused variable is_cur_bidi

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 27805 applied with additional changes from upstream: 8523985b411da9974d4994af1b438a6dafba79c8
Component: web-platform-tests → geckodriver
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 171 tests and 18 subtests

Status Summary

Firefox

OK : 166
PASS : 2164
FAIL : 138
ERROR : 8

Chrome

OK : 166
PASS : 2171
FAIL : 134
ERROR : 5

Safari

OK : 164
PASS : 1753
FAIL : 482
TIMEOUT: 2
ERROR : 39

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/webdriver/tests/element_clear/clear.py
test_contenteditable: FAIL
/webdriver/tests/element_send_keys/events.py
test_file_upload: FAIL
/webdriver/tests/execute_async_script/promise.py
test_await_promise_resolve: FAIL
/webdriver/tests/execute_script/promise.py
test_await_promise_resolve: FAIL
/webdriver/tests/get_element_property/get.py
test_primitives["foobar"-foobar]: FAIL
test_primitives[42-42]: FAIL
test_primitives[js_primitive2-py_primitive2]: FAIL
test_primitives[js_primitive3-py_primitive3]: FAIL
test_primitives_set_by_execute_script["foobar"-foobar]: FAIL
test_primitives_set_by_execute_script[42-42]: FAIL
test_primitives_set_by_execute_script[js_primitive2-py_primitive2]: FAIL
test_primitives_set_by_execute_script[js_primitive3-py_primitive3]: FAIL
/webdriver/tests/get_window_rect/user_prompts.py
test_accept_and_notify[capabilities0-alert-None]: FAIL
test_dismiss[capabilities0-alert-None]: FAIL
test_dismiss_and_notify[capabilities0-alert-None]: FAIL
/webdriver/tests/maximize_window/maximize.py
test_maximize_when_resized_to_max_size: FAIL
/webdriver/tests/maximize_window/user_prompts.py
test_default[alert-None]: FAIL
/webdriver/tests/perform_actions/key_events.py
test_modifier_key_sends_correct_events[\ue03d-META]: FAIL
test_special_key_sends_keydown[ADD-expected0]: FAIL
test_special_key_sends_keydown[META-expected30]: FAIL
test_special_key_sends_keydown[NUMPAD4-expected37]: FAIL
test_special_key_sends_keydown[NUMPAD5-expected38]: FAIL
test_special_key_sends_keydown[PAGE_DOWN-expected43]: FAIL
test_special_key_sends_keydown[PAGE_UP-expected44]: FAIL
test_special_key_sends_keydown[SUBTRACT-expected66]: FAIL
/webdriver/tests/perform_actions/validity.py
test_pause_positive_integer[none]: FAIL
test_pause_positive_integer[key]: FAIL
test_pause_positive_integer[pointer]: FAIL
/webdriver/tests/perform_actions/wheel.py
test_no_top_browsing_context: FAIL
test_no_browsing_context: FAIL
/webdriver/tests/set_window_rect/user_prompts.py
test_ignore[capabilities0-alert]: FAIL

New Tests That Don't Pass

/webdriver/tests/bidi/new_session/connect.py
test_websocket_url_connect[capabilities0]: ERROR (Chrome: PASS, Safari: ERROR)
test_bidi_session_send: ERROR (Chrome: PASS, Safari: ERROR)
test_bidi_session_with_different_capability[capabilities0]: ERROR (Chrome: PASS, Safari: ERROR)
/webdriver/tests/element_clear/clear.py
test_contenteditable: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/element_click/interactability.py
test_element_not_visible_overflow_hidden: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/element_send_keys/events.py
test_file_upload: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/execute_async_script/promise.py
test_await_promise_resolve: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/execute_script/json_serialize_windowproxy.py
test_initial_window: FAIL (Chrome: FAIL, Safari: FAIL)
test_window_open: FAIL (Chrome: FAIL, Safari: FAIL)
test_frame: FAIL (Chrome: FAIL, Safari: FAIL)
/webdriver/tests/execute_script/promise.py
test_await_promise_resolve: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/find_element_from_element/find.py
test_parent_of_document_node_errors: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/find_element_from_shadow_root/find.py
test_null_parameter_value: FAIL (Chrome: FAIL, Safari: FAIL)
test_no_top_browsing_context: FAIL (Chrome: FAIL, Safari: FAIL)
test_no_browsing_context: FAIL (Chrome: FAIL, Safari: FAIL)
test_invalid_using_argument[a]: FAIL (Chrome: FAIL, Safari: FAIL)
test_invalid_using_argument[True]: FAIL (Chrome: FAIL, Safari: FAIL)
test_invalid_using_argument[None]: FAIL (Chrome: FAIL, Safari: FAIL)
test_invalid_using_argument[1]: FAIL (Chrome: FAIL, Safari: FAIL)
test_invalid_using_argument[using4]: FAIL (Chrome: FAIL, Safari: FAIL)
test_invalid_using_argument[using5]: FAIL (Chrome: FAIL, Safari: FAIL)
test_invalid_selector_argument[None]: FAIL (Chrome: FAIL, Safari: FAIL)
test_invalid_selector_argument[value1]: FAIL (Chrome: FAIL, Safari: FAIL)
test_invalid_selector_argument[value2]: FAIL (Chrome: FAIL, Safari: FAIL)
test_detached_shadow_root: FAIL (Chrome: FAIL, Safari: FAIL)
test_found_element_equivalence: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element[css selector-#linkText]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element[link text-full link text]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element[partial link text-link text]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element[tag name-a]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element[xpath-//a]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_link_text[<a href=#>link text</a>-link text]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_link_text[<a href=#> link text </a>-link text]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_link_text[<a href=#>link<br>text</a>-link\ntext]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_link_text[<a href=#>link&text</a>-link&text]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_link_text[<a href=#>LINK TEXT</a>-LINK TEXT]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_link_text[<a href=# style='text-transform: uppercase'>link text</a>-LINK TEXT]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_partial_link_text[<a href=#>partial link text</a>-link]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_partial_link_text[<a href=#> partial link text </a>-link]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_partial_link_text[<a href=#>partial link text</a>-k t]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_partial_link_text[<a href=#>partial link<br>text</a>-k\nt]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_partial_link_text[<a href=#>partial link&text</a>-k&t]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_partial_link_text[<a href=#>PARTIAL LINK TEXT</a>-LINK]: FAIL (Chrome: FAIL, Safari: FAIL)
test_find_element_partial_link_text[<a href=# style='text-transform: uppercase'>partial link text</a>-LINK]: FAIL (Chrome: FAIL, Safari: FAIL)
test_no_element[css selector-#wontExist]: FAIL (Chrome: FAIL, Safari: FAIL)
/webdriver/tests/find_element_from_shadow_root/user_prompts.py
test_accept[capabilities0-alert-None]: FAIL (Chrome: FAIL, Safari: FAIL)
test_accept[capabilities0-confirm-True]: FAIL (Chrome: FAIL, Safari: FAIL)
test_accept[capabilities0-prompt-]: FAIL (Chrome: FAIL, Safari: FAIL)
test_accept_and_notify[capabilities0-alert-None]: FAIL (Chrome: FAIL, Safari: FAIL)
test_accept_and_notify[capabilities0-confirm-True]: FAIL (Chrome: FAIL, Safari: FAIL)
test_accept_and_notify[capabilities0-prompt-]: FAIL (Chrome: FAIL, Safari: FAIL)
test_dismiss[capabilities0-alert-None]: FAIL (Chrome: FAIL, Safari: FAIL)
test_dismiss[capabilities0-confirm-False]: FAIL (Chrome: FAIL, Safari: FAIL)
test_dismiss[capabilities0-prompt-None]: FAIL (Chrome: FAIL, Safari: FAIL)
test_dismiss_and_notify[capabilities0-alert-None]: FAIL (Chrome: FAIL, Safari: FAIL)
test_dismiss_and_notify[capabilities0-confirm-False]: FAIL (Chrome: FAIL, Safari: FAIL)
test_dismiss_and_notify[capabilities0-prompt-None]: FAIL (Chrome: FAIL, Safari: FAIL)
test_ignore[capabilities0-alert]: FAIL (Chrome: FAIL, Safari: FAIL)
test_ignore[capabilities0-confirm]: FAIL (Chrome: FAIL, Safari: FAIL)
test_ignore[capabilities0-prompt]: FAIL (Chrome: FAIL, Safari: FAIL)
test_default[alert-None]: FAIL (Chrome: FAIL, Safari: FAIL)
test_default[confirm-False]: FAIL (Chrome: FAIL, Safari: FAIL)
test_default[prompt-None]: FAIL (Chrome: FAIL, Safari: FAIL)
/webdriver/tests/find_elements_from_element/find.py
test_parent_of_document_node_errors: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/find_elements_from_shadow_root/find.py: ERROR (Chrome: ERROR, Safari: ERROR)
/webdriver/tests/find_elements_from_shadow_root/user_prompts.py: ERROR (Chrome: ERROR, Safari: ERROR)
/webdriver/tests/get_computed_label/get.py: ERROR (Chrome: ERROR, Safari: ERROR)
/webdriver/tests/get_computed_role/get.py: ERROR (Chrome: ERROR, Safari: ERROR)
/webdriver/tests/get_element_property/get.py
test_primitives["foobar"-foobar]: FAIL (Chrome: PASS, Safari: PASS)
test_primitives[42-42]: FAIL (Chrome: PASS, Safari: PASS)
test_primitives[js_primitive2-py_primitive2]: FAIL (Chrome: PASS, Safari: PASS)
test_primitives[js_primitive3-py_primitive3]: FAIL (Chrome: PASS, Safari: PASS)
test_primitives_set_by_execute_script["foobar"-foobar]: FAIL (Chrome: PASS, Safari: PASS)
test_primitives_set_by_execute_script[42-42]: FAIL (Chrome: PASS, Safari: PASS)
test_primitives_set_by_execute_script[js_primitive2-py_primitive2]: FAIL (Chrome: PASS, Safari: PASS)
test_primitives_set_by_execute_script[js_primitive3-py_primitive3]: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/get_element_shadow_root/get.py
test_no_top_browsing_context: FAIL (Chrome: FAIL, Safari: FAIL)
test_no_browsing_context: FAIL (Chrome: FAIL, Safari: FAIL)
test_element_not_found: FAIL (Chrome: FAIL, Safari: FAIL)
test_element_stale: FAIL (Chrome: FAIL, Safari: FAIL)
test_get_shadow_root: FAIL (Chrome: FAIL, Safari: FAIL)
test_no_shadow_root: FAIL (Chrome: FAIL, Safari: FAIL)
/webdriver/tests/get_element_shadow_root/user_prompts.py: ERROR (Chrome: ERROR, Safari: ERROR)
/webdriver/tests/get_window_rect/user_prompts.py
test_accept_and_notify[capabilities0-alert-None]: FAIL (Chrome: PASS, Safari: PASS)
test_dismiss[capabilities0-alert-None]: FAIL (Chrome: PASS, Safari: PASS)
test_dismiss_and_notify[capabilities0-alert-None]: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/maximize_window/maximize.py
test_maximize_when_resized_to_max_size: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/maximize_window/user_prompts.py
test_default[alert-None]: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/new_session/default_values.py
test_no_capabilites: FAIL (Chrome: PASS, Safari: FAIL)
test_desired: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/new_session/response.py
test_capability_type[proxy-dict]: FAIL (Chrome: PASS, Safari: FAIL)
test_capability_default_value[proxy-default_value2]: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/new_session/websocket_url.py
test_websocket_url: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/perform_actions/key_events.py
test_modifier_key_sends_correct_events[\ue03d-META]: FAIL (Chrome: PASS, Safari: PASS)
test_modifier_key_sends_correct_events[\ue053-R_META]: FAIL (Chrome: PASS, Safari: FAIL)
test_special_key_sends_keydown[ADD-expected0]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[META-expected30]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[NUMPAD4-expected37]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[NUMPAD5-expected38]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[PAGE_DOWN-expected43]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[PAGE_UP-expected44]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[R_META-expected58]: FAIL (Chrome: PASS, Safari: FAIL)
test_special_key_sends_keydown[SEPARATOR-expected63]: FAIL (Chrome: PASS, Safari: FAIL)
test_special_key_sends_keydown[SUBTRACT-expected66]: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/perform_actions/pointer.py
test_pen_pointer_properties: FAIL (Chrome: FAIL, Safari: FAIL)
test_touch_pointer_properties: FAIL (Chrome: PASS, Safari: FAIL)
test_drag_and_drop_with_draggable_element[0]: FAIL (Chrome: FAIL, Safari: FAIL)
test_drag_and_drop_with_draggable_element[300]: FAIL (Chrome: FAIL, Safari: FAIL)
test_drag_and_drop_with_draggable_element[800]: FAIL (Chrome: FAIL, Safari: FAIL)
/webdriver/tests/perform_actions/pointer_tripleclick.py
test_tripleclick_at_coordinates: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/perform_actions/validity.py
test_pause_positive_integer[none]: FAIL (Chrome: PASS, Safari: PASS)
test_pause_positive_integer[key]: FAIL (Chrome: PASS, Safari: PASS)
test_pause_positive_integer[pointer]: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/perform_actions/wheel.py
test_null_response_value: FAIL (Chrome: PASS, Safari: FAIL)
test_no_top_browsing_context: FAIL (Chrome: PASS, Safari: PASS)
test_no_browsing_context: FAIL (Chrome: PASS, Safari: PASS)
test_wheel_scroll: FAIL (Chrome: PASS, Safari: FAIL)
test_wheel_scroll_overflow: FAIL (Chrome: PASS, Safari: FAIL)
test_wheel_scroll_iframe: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/permissions/set.py
test_invalid_parameters[capabilities0-parameters0]: FAIL (Chrome: PASS, Safari: ERROR)
test_invalid_parameters[capabilities0-parameters1]: FAIL (Chrome: PASS, Safari: ERROR)
test_invalid_parameters[capabilities0-parameters2]: FAIL (Chrome: PASS, Safari: ERROR)
test_invalid_parameters[capabilities0-parameters3]: FAIL (Chrome: PASS, Safari: ERROR)
test_invalid_parameters[capabilities0-parameters4]: FAIL (Chrome: PASS, Safari: ERROR)
test_invalid_parameters[capabilities0-parameters5]: FAIL (Chrome: PASS, Safari: ERROR)
test_invalid_parameters[capabilities0-parameters6]: FAIL (Chrome: PASS, Safari: ERROR)
test_invalid_parameters[capabilities0-parameters7]: FAIL (Chrome: PASS, Safari: ERROR)
test_non_secure_context[granted]: FAIL (Chrome: PASS, Safari: FAIL)
test_non_secure_context[denied]: FAIL (Chrome: PASS, Safari: FAIL)
test_non_secure_context[prompt]: FAIL (Chrome: PASS, Safari: FAIL)
test_set_to_state[capabilities0-realmSetting0-granted]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state[capabilities0-realmSetting0-denied]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state[capabilities0-realmSetting0-prompt]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state[capabilities0-realmSetting1-granted]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state[capabilities0-realmSetting1-denied]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state[capabilities0-realmSetting1-prompt]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state[capabilities0-realmSetting2-granted]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state[capabilities0-realmSetting2-denied]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state[capabilities0-realmSetting2-prompt]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state_cross_realm[capabilities0-realmSetting0-granted]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state_cross_realm[capabilities0-realmSetting0-denied]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state_cross_realm[capabilities0-realmSetting0-prompt]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state_cross_realm[capabilities0-realmSetting1-granted]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state_cross_realm[capabilities0-realmSetting1-denied]: FAIL (Chrome: PASS, Safari: ERROR)
test_set_to_state_cross_realm[capabilities0-realmSetting1-prompt]: FAIL (Chrome: PASS, Safari: ERROR)
/webdriver/tests/set_window_rect/user_prompts.py
test_ignore[capabilities0-alert]: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd6fadc6ec0e
[wpt PR 27805] - Remove unused variable and move reset session to a function, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e74b18c320e3
[wpt PR 27805] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cd6fadc6ec0e
https://hg.mozilla.org/mozilla-central/rev/e74b18c320e3

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.