1695434 - chat settings aren't persistent

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[diomede979]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.190 Safari/537.36

Steps to reproduce:

edit > account settings, then go to any chat IRC profile and edit the checkbox "show messages from server". then close e reopen account settings.

Actual results:

the change has not being saved. this happens also for "Use SSL" checkbox setting if the account is online.

Expected results:

the change should be saved.

Comment 1

[Magnus Melin [:mkmelin]]

Probably from bug 1610445.
The values must be saved since moving from account to account they get restored. But not after closing the acccount manager tab.

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1695434 - Trigger pref save from dynamic chat settings. r=mkmelin

The dynamic settings are added during onPreInit, which fires after load
for the content pane when switching between accounts. As such, the
save handlers have to be added manually.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/153f43c89939
Trigger pref save from dynamic chat settings. r=mkmelin

Comment 4

[Magnus Melin [:mkmelin]]

Should probably go on 78.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9217794 [details]
Bug 1695434 - Trigger pref save from dynamic chat settings. r=mkmelin

[Approval Request Comment]
User impact if declined: Some chat settings not saved
Testing completed (on c-c, etc.): c-c and 90 beta
Risk to taking this patch (and alternatives if risky): not risky

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9217794 [details]
Bug 1695434 - Trigger pref save from dynamic chat settings. r=mkmelin

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.12.0:
https://hg.mozilla.org/releases/comm-esr78/rev/7460a98d02ca