Closed Bug 1695571 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27832 - [TablesNG] Redo table-layout:fixed width:100% sizing

Categories

(Core :: Layout: Tables, task, P4)

Product:
Core
Component:
Layout: Tables
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27832 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27832
Details from upstream follow.

b'Aleks Totic <atotic@chromium.org>' wrote:

[TablesNG] Redo table-layout:fixed width:100% sizing

The original fix for 1181477 was to not give tables inflinite
intrinsic width inside Flex/Grid.

This fix was incorrect. The reason for bad layouts was that table's
max width was LayoutUnit::Max(). Changing the table's max width
to 100,000 makes everything match FF/Legacy.

This CL changes kTableMaxWidth to 100,000, reverts Flex/Grid
exception, and updates test expectations.

Bug: 1183072,1181477
Change-Id: I91fdd2fc66b0602bb5d38e7329f1fb41f6e65d54
Reviewed-on: https://chromium-review.googlesource.com/2727195
WPT-Export-Revision: e7baf8d46625a688c71dfd21ec158e80c52897de

PR 27832 applied with additional changes from upstream: f1becf46b07bfa360c36a6cbcb30a4dc9f48058a
Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 6

Chrome

OK : 1
PASS: 6

Safari

OK : 1
PASS: 5
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33f915450b2c
[wpt PR 27832] - [TablesNG] Redo table-layout:fixed width:100% sizing, a=testonly

https://hg.mozilla.org/mozilla-central/rev/33f915450b2c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.