1695579 - In the new drag-and-drop feature for attachments, the two panels should be swapped.

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, enhancement, P3)

Description

[dittnamn]

Attachment: Drag-and-drop overlay.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

The new drag-and-drop feature for attachments in Thunderbird 87.0b1 might be a good inprovement. However, users that have used drag-and-drop earlier to drop images inline, might be confused to need to drop the image on another place than the text is.

Actual results:

In the current beta, the left panel is "Add as attachment" and the right panel is "Add inline" (a bit unsure about the exact translation).

Expected results:

As most of the text is in the left part of the screen, the probability is high that the user wants to drag and drop it into the left part of the screen to add the image inline. The earlier attachment box was also in the right part of the screen, so users that used to drag-and-drop to attachment will probably assume that it's still in the same place.

Therefore, I think that "Add inline" should be on the left part of the screen when using a LTR language. For RTL languages, the opposite might be good.

Comment 1

[Thomas D. (:thomas8)]

Alex, this makes sense exactly as described in comment 0.

• Let's swap the landing zone panels.
• Also, I suggest to change "Append inline" to "Insert inline". Append is an unknown term in this context even to me as an advanced user, whereas "Insert" is exactly matching the main menu action which we offer for inserting things inline.
• Please make capitalization consistent, either:
  • Add as Attachment and Insert Inline, or:
  • Add as attachment and Insert inline. I like lowercase better, more readable and more natural. These landing zones definitely don't look like a traditional menu...

Comment 2

[Alessandro Castellani [:aleca]]

Sounds good, I'll take care of this.
Thanks for the suggestions.

Add as attachment and Insert inline. I like lowercase better

Me too.

Comment 3

[Alessandro Castellani [:aleca]]

Making this dependent on bug 1695521 since some code improvements are necessary and they're touching related areas.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1695579-drop-containers.diff

This should do it.
Richard, is the support for RTL correct the way I did it?
This needs the patch on bug 1695521 to properly apply.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: screenshot.png

This is how it looks in RTL mode.

Do you want, that Insert inline is always on the left side or to be depending of the direction? If the first your "row-reverse" is correct. But I think this should be direction dependent.

As you can see, the icons overwrite the text. You need a background-position: right; for them in RTL mode.

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: 1695579-drop-containers.diff

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9207002 [details] [diff] [review]
1695579-drop-containers.diff

Better now. Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/23baf14e403a
Swap the drop containers position of the attachment drop overlay. r=Paenglab

Comment 9

[Thomas D. (:thomas8)]

Awesome, thanks everyone, great teamwork, and blazing fast!

Dittnamn, thank you for your request for enhancement (RFE), which has been implemented within 3 days of your report.
It will now ride the trains and be available in the next major release of Thunderbird in a couple of months.

Comment 10

[Alessandro Castellani [:aleca]]

Comment on attachment 9207002 [details] [diff] [review]
1695579-drop-containers.diff

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Defective support for RTL users
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): very low

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9207002 [details] [diff] [review]
1695579-drop-containers.diff

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 87.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/596432f495ed