1695694 - [Proton] Windows 10 Context menu separator colours need updating

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: separator-proton.png

Affected versions

• Firefox 88.0a1 (BuildId:20210301093612)

Affected platforms

• Windows 10 64bit

Unaffected platforms

• macOS 10.14
• Ubuntu 20.04

Preconditions

• Set your monitor settings to high contrast values (~90%)

Steps to reproduce

1. Launch Firefox.
2. Enable proton context menu.
3. Right click on the address bar.

Expected result

• The separator is visible.

Actual result

• The separator is barely visible.

Regression Range

• I don’t think that this is a regression.

Notes

• For further information regarding this issue please observe the attached screenshots
• This issue is only reproducible with proton enabled.

Comment 1

[:Gijs (he/him)]

The design has #52525E for dark mode and #E0E0E6 for light mode.

Comment 2

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #1)

The design has #52525E for dark mode and #E0E0E6 for light mode.

Looks like this is basically the menuitem-hover-background-color variable, with the dark mode one still needing updates to match the new dark theme spec.

Comment 3

[Micah [:mtigley] (she/her)]

Attachment: Bug 1695694 - Update context menu separator colors on Windows. r=Gijs!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dda8cf18710c
Update context menu separator colors on Windows. r=Gijs

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dda8cf18710c

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Verified that this is fixed on Windows 10 using latest Nightly 88.0a1.