1695880 - Consider removing the username as a needing value when importing a CSV file

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P2)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: CSV file missing username.gif

[Notes]:

• Considering the fact that logins can be created or saved without a username, this rule can also be applied when importing a CSV file that contains logins without a username.

[Affected versions]:

• Firefox Nightly 88.0a1 (Build ID:20210301220015);

[Affected Platforms]:

• Windows 10 x64;
• macOS 10.15.7;
• Linux Mint 20 x64;

[Prerequisites]:

• Have the latest Firefox Nightly installed.
• Have a CSV file that contains a login without the username.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to "about:logins" page.
3. Open the menu and click the "Import from a File..." option.
4. Select and open the CSV file.
5. Click the "View detailed Import Summary" link.
6. Observe the import report.

[Expected result]:

• The login that doesn't have a username is imported.

[Actual result]:

• The login is not imported and is recognized as an error with the "Missing username".

[Additional Notes]:

• Attached a screen recording of the issue.

Comment 1

[Andrei Petcu]

Attachment: Bug 1695880 Remove the username as a needing value when importing a CSV file

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4109b7bca7a
Remove the username as a needing value when importing a CSV file r=tgiles

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d4109b7bca7a

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this bug on the latest Nightly 88.0a1 build (Build ID: 20210303215027) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20 x64.

• The username is no longer a needed value when importing a CSV file. The logins that don't have a username are correctly imported.