Closed Bug 1695880 Opened 9 months ago Closed 9 months ago

Consider removing the username as a needing value when importing a CSV file

Categories

(Firefox :: about:logins, enhancement, P2)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- verified

People

(Reporter: cmuntean, Assigned: petcuandrei)

References

Details

Attachments

(2 files)

[Notes]:

  • Considering the fact that logins can be created or saved without a username, this rule can also be applied when importing a CSV file that contains logins without a username.

[Affected versions]:

  • Firefox Nightly 88.0a1 (Build ID:20210301220015);

[Affected Platforms]:

  • Windows 10 x64;
  • macOS 10.15.7;
  • Linux Mint 20 x64;

[Prerequisites]:

  • Have the latest Firefox Nightly installed.
  • Have a CSV file that contains a login without the username.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites.
  2. Navigate to "about:logins" page.
  3. Open the menu and click the "Import from a File..." option.
  4. Select and open the CSV file.
  5. Click the "View detailed Import Summary" link.
  6. Observe the import report.

[Expected result]:

  • The login that doesn't have a username is imported.

[Actual result]:

  • The login is not imported and is recognized as an error with the "Missing username".

[Additional Notes]:

  • Attached a screen recording of the issue.
Assignee: nobody → petcuandrei
Status: NEW → ASSIGNED
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4109b7bca7a
Remove the username as a needing value when importing a CSV file r=tgiles
Severity: -- → N/A
Priority: -- → P2
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

I have verified this bug on the latest Nightly 88.0a1 build (Build ID: 20210303215027) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20 x64.

  • The username is no longer a needed value when importing a CSV file. The logins that don't have a username are correctly imported.
Status: RESOLVED → VERIFIED
Blocks: 1649940, 1700581
No longer blocks: 1650675
You need to log in before you can comment on or make changes to this bug.