Closed Bug 1696073 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27869 - Fix VideoFrame orientation issues, remove public accessor.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox88 fixed)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27869 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27869
Details from upstream follow.

b'Dale Curtis <dalecurtis@chromium.org>' wrote:

Fix VideoFrame orientation issues, remove public accessor.

Since we aren't quite sure how we want to expose orientation yet,
remove the public accessor from the IDL. As part of doing this
add a bunch of tests for orientation and fix the bugs they found.

As part of fixing these issues, VideoFrameImageUtil now prefers
soft flips to hard flips. Otherwise when using the non SkImage
path, Canvas 'image-orientation: none' won't work properly.

Bug: 1140137,1182435
Test: Lots of new tests.
Change-Id: Ib86754303db473c5829e6a7cbe682d9847b33b2e
Reviewed-on: https://chromium-review.googlesource.com/2730247
WPT-Export-Revision: 87bfa42f1c33c0d34d4a723f7826e043a4fabfd4

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 13 subtests

Status Summary

Firefox

OK : 3
FAIL : 34

Chrome

OK : 1
PASS : 4
CRASH: 2
FAIL : 4

Safari

OK : 3
FAIL : 34

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/image-decoder-image-orientation-none.html
Test JPEG w/ EXIF orientation top-left on canvas w/o orientation: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation top-right on canvas w/o orientation.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-right on canvas w/o orientation.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-left on canvas w/o orientation.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation left-top on canvas w/o orientation.: FAIL (Chrome: FAIL, Safari: FAIL)
Test JPEG w/ EXIF orientation right-top on canvas w/o orientation.: FAIL (Chrome: FAIL, Safari: FAIL)
Test JPEG w/ EXIF orientation right-bottom on canvas w/o orientation.: FAIL (Chrome: FAIL, Safari: FAIL)
Test JPEG w/ EXIF orientation left-bottom on canvas w/o orientation.: FAIL (Chrome: FAIL, Safari: FAIL)
/webcodecs/image-decoder.any.html
Test JPEG image decoding.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation top-left.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation top-right.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-right.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-left.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation left-top.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation right-top.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation right-bottom.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation left-bottom.: FAIL (Safari: FAIL)
Test PNG image decoding.: FAIL (Safari: FAIL)
Test AVIF image decoding.: FAIL (Safari: FAIL)
Test WEBP image decoding.: FAIL (Safari: FAIL)
Test GIF image decoding.: FAIL (Safari: FAIL)
/webcodecs/image-decoder.any.worker.html
Test JPEG image decoding.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation top-left.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation top-right.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-right.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-left.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation left-top.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation right-top.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation right-bottom.: FAIL (Safari: FAIL)
Test JPEG w/ EXIF orientation left-bottom.: FAIL (Safari: FAIL)
Test PNG image decoding.: FAIL (Safari: FAIL)
Test AVIF image decoding.: FAIL (Safari: FAIL)
Test WEBP image decoding.: FAIL (Safari: FAIL)
Test GIF image decoding.: FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be567fcdc040
[wpt PR 27869] - Fix VideoFrame orientation issues, remove public accessor., a=testonly
https://hg.mozilla.org/integration/autoland/rev/87aaae53c813
[wpt PR 27869] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/be567fcdc040
https://hg.mozilla.org/mozilla-central/rev/87aaae53c813

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.