1696267 - Typing a trailing space causes search history and suggestions that match the input/heuristic query to go from hidden to shown

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Drew Willcoxon :adw]

STR

1. Do a search for "testing"
2. Type "testing" again but don't hit enter
3. Verify that your "testing" search history is not shown
4. Type a trailing space

The "testing" search history is shown again, but it shouldn't be.

AFAICT we don't properly dedupe remote suggestions in this context either, but it's unlikely an engine would actually return a suggestion that is the trimmed version of the search string.

Adrian found this in bug 1694237 comment 12. It should be an easy fix, so I'll go ahead and do it now.

This is not a (recent) regression and goes back to at least 78 according to Adrian.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1696267 - Dedupe urlbar search suggestions and search history accounting for leading and trailing spaces.

This also fixes a potential problem when deduping SERPs against form history:
We're creating SERP URLs based on the lowercased version of SERP terms instead
of the terms as is. That means we won't detect example.com/?q=foo and
example.com/?q=FOO as being dupes, but I think we should.

I updated the test to check for leading/trailing spaces as well as case.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc5826d52707e4e66982899993c851b8d6155315

Comment 3

[Adrian Florinescu [:aflorinescu]]

This is not a (recent) regression and goes back to at least 78 according to Adrian.

Sad to say that Adrian was a bit wrong (my statement was that it is reproducible back to 78-81), but again, I wasn't looking specific to this particular bug. So, the mozregression points to Bug 1645324 - Move the omnibox heuristic result to the omnibox provider. r=adw, which IMO fits the regressor description.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8857f3757686
Dedupe urlbar search suggestions and search history accounting for leading and trailing spaces. r=mak

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8857f3757686

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Is this worth uplifting to 87 or should it ride the trains?

Comment 7

[Drew Willcoxon :adw]

I think this should just ride the trains because:

• This goes back to 80 so it's not super urgent
• This isn't really a huge bug to begin with
• The patch is pretty simple but it touches code that's complex so there's a (probably small) possibility of introducing subtle bugs
• We're already in late beta

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

I've reproduced the issue using Fx88.0a1.
The issue is verified fixed in Fx88.0b9 and Fx89.0a1 on Windows 10 and Ubuntu 18.04. The history entry is no longer displayed when adding a trailing space to the search term.