Closed
Bug 1696418
Opened 4 years ago
Closed 4 years ago
Make permission panels not defined in PermissionUI.jsm unopinionated when Proton is enabled
Categories
(Firefox :: Messaging System, task, P3)
Firefox
Messaging System
Tracking
()
RESOLVED
FIXED
88 Branch
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-door-hangers])
Attachments
(1 file)
Bug 1696286 made it possible for PopupNotifications to be "unopinionated" (they don't style the main action differently from secondary actions). The permission panels defined in PermissionUI all inherit this unopinionated property if browser.proton.doorhangers.enabled
is true
.
There are, however, a number of permission panels defined outside of PermissionUI.jsm which need to also be made unopinionated. They are:
- WebRTC permission panel
- IndexedDB
- WebAuthn
- DRM
- Save/Updated Password panels
- Canvas
Notably absent from this list are the WebExtension panels for both adding and update the permissions for an extension - for these, we will continue to highlight the main action.
Assignee | ||
Updated•4 years ago
|
Priority: -- → P3
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-403
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72b2db97f3fa
Don't highlight the default action for more permission panels when Proton is enabled. r=sfoster
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•