1696444 - The Firefox icon from the task bar is no longer displayed if Firefox is pinned again after it is already pinned

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Robert Martin [:romartin], Ecosystem QA]

Attachment: 2021-03-04_17h47_14.gif

[Affected Versions]:

• Firefox Nightly 88.0a1 (Build ID: 20210304092248)
• Firefox Beta 87.0b7 (Build ID: 20210302185821)
• Firefox Release 86.0 (Build ID: 20210222142601)

[Affected Platforms]:

• Windows 10 Version: 2004 x64
• Windows 10 Version: 2H20 x64

[Prerequisites]:

• Have a new Firefox profile created.
• Have the user.js saved in the profile folder before starting it.

[Steps to reproduce]:

1. Start the Firefox Browser using the “--first-startup” arg.
2. Click the “Pin to Taskbar” button.
3. Click the “Back” browser button.
4. Click the “Pin to Taskbar” button and observe the Windows TaskBar.

[Expected results]:

• The Firefox Browser is pinned and the Firefox icon is correctly displayed.

[Actual results]:

• The Firefox Browser is pinned and the Firefox icon is replaced with a placeholder icon.

[Notes]:

• This issue might affect users that will be enrolled in future experiments that are based on this feature.
• Unpinning and pinning again the Firefox will fix the icon.

Comment 1

[Robert Martin [:romartin], Ecosystem QA]

Hey @Ed,

Can you please take a look at this?

Comment 2

[Ed Lee :Mardak]

Does the placeholder icon still appear after restarting Windows? Looks like from attachment 9206937 [details] restarting Firefox isn't enough.

Does this only happen if Firefox is already pinned, so only really happens if the user goes back and pins again? At least for the experiment, we assume we target users who wouldn't have Firefox pinned by the installer, but yes the back button does allow the user to run into this.

Comment 3

[Robert Martin [:romartin], Ecosystem QA]

Hey @Ed,

I just verified if the issue is still reproducible after restarting Windows and it is not reproducible. The Firefox icon is correctly displayed after a Windows restart.

Comment 4

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Linking an old bug that might be related.

Comment 5

[Ed Lee :Mardak]

Attachment: Bug 1696444 - Pin Firefox only if not already pinned to avoid changing taskbar icon r?andreio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29d477a1a826
Pin Firefox only if not already pinned to avoid changing taskbar icon r=andreio

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset 29d477a1a826 (Bug 1696444) for causing failures in browser_sma_docs.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=I9k2ME0uRsq6hC5XYwVRng.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=29d477a1a826448e0f83846b69a326b89c5219bf

Failure log: https://treeherder.mozilla.org/logviewer?job_id=333791013&repo=autoland&lineNumber=2995

Backout: https://hg.mozilla.org/integration/autoland/rev/edc9131587c451bc42fcff877ba01474f7d9f2ff

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0899f13f701c
Pin Firefox only if not already pinned to avoid changing taskbar icon r=andreio

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0899f13f701c

Comment 10

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the issue is no longer reproducible by following the steps from the description using Firefox Nightly 89.0a1 (Build ID: 20210323214359) and Firefox Beta 88.0b2 (Build ID: 202103231950052) on Windows 10 x64 version 1903, 2004, and 20H2.