1696516 - --with-gl-provider config option seems to be broken

Status: NEW

(Core :: Graphics, defect, P3)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I tried building with --with-gl-provider=GLX (also X11) and got this multiple-definition error:

 1:34.14 In file included from Unified_cpp_dom_canvas1.cpp:110:
 1:34.14 In file included from /home/jld/src/gecko-dev/dom/canvas/WebGLContext.cpp:23:
 1:34.14 In file included from /home/jld/src/gecko-dev/gfx/gl/GLContextProvider.h:84:
 1:34.14 /home/jld/src/gecko-dev/gfx/gl/GLContextProviderImpl.h:17:7: error: redefinition of 'GLContextProviderGLX'
 1:34.14 class GL_CONTEXT_PROVIDER_NAME {
 1:34.14       ^
 1:34.14 /home/jld/src/gecko-dev/gfx/gl/GLContextProvider.h:83:36: note: expanded from macro 'GL_CONTEXT_PROVIDER_NAME'
 1:34.14 #  define GL_CONTEXT_PROVIDER_NAME MOZ_GL_PROVIDER
 1:34.14                                    ^
 1:34.14 /home/jld/src/obj.gecko-dev/obj-x86_64-pc-linux-gnu/mozilla-config.h:164:25: note: expanded from macro 'MOZ_GL_PROVIDER'
 1:34.14 #define MOZ_GL_PROVIDER GLContextProviderGLX
 1:34.15                         ^
 1:34.15 /home/jld/src/gecko-dev/gfx/gl/GLContextProviderImpl.h:17:7: note: previous definition is here
 1:34.15 class GL_CONTEXT_PROVIDER_NAME {
 1:34.15       ^
 1:34.15 /home/jld/src/gecko-dev/gfx/gl/GLContextProvider.h:52:36: note: expanded from macro 'GL_CONTEXT_PROVIDER_NAME'
 1:34.15 #  define GL_CONTEXT_PROVIDER_NAME GLContextProviderGLX
 1:34.15                                    ^
 1:34.15 /home/jld/src/gecko-dev/gfx/gl/GLContextProvider.h:86:11: warning: 'GL_CONTEXT_PROVIDER_DEFAULT' macro redefined [-Wmacro-redefined]
 1:34.15 #  define GL_CONTEXT_PROVIDER_DEFAULT MOZ_GL_PROVIDER
 1:34.15           ^
 1:34.15 /home/jld/src/gecko-dev/gfx/gl/GLContextProvider.h:62:13: note: previous definition is here
 1:34.15 #    define GL_CONTEXT_PROVIDER_DEFAULT GLContextProviderWayland
 1:34.15             ^
 1:34.15 1 warning and 1 error generated.

If this isn't expected to work anymore, maybe it should be removed?