1696563 - Modal styles when RDM is enabled need to be fixed

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Description

[Micah [:mtigley] (she/her)]

The new modal styles introduced in Bug 1693277 don't work well with Responsive Design Mode. This is because when RDM is enabled, we set position: fixed on the dialogStack in https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/devtools/client/responsive/responsive-browser.css#132 and it ends up messing with the modal's sizing.

One approach is to use a resize observer on the dialogStack to set the height of the modal. This is actually similar to what we're doing for the RDM toolbar https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/devtools/client/responsive/ui.js#241-245.

We should try exploring a more CSS-oriented (with maybe a little help from JS) to fix this issue. But at least we have a fallback if this proves too difficult.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1693277

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1696563 - Reuse RDM's toolbar resize observer to set the size of the dialogStack

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1918588414c
Reuse RDM's toolbar resize observer to set the size of the dialogStack r=Gijs

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a1918588414c