Open Bug 1696663 Opened 5 years ago Updated 5 years ago

Perform a clobber build if build logic changes (recursivemake.py, etc)

Categories

(Firefox Build System :: General, enhancement, P3)

Product:
Firefox Build System
Component:
General
Type:
enhancement

Tracking

(Not tracked)

Status:
UNCONFIRMED

People

(Reporter: mac198442, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

tried to backport a patch to recursivemake.py

Actual results:

build failed unless i decided to do a clobber

Expected results:

should have said a clobber is required

Product: Core → Firefox Build System

Yeah, our sanctity of incremental builds is not very strong - there's a lot of files that change how incremental builds are performed (including recursivemake.py), and a clobber should be needed if any of them are changed. I agree that this should be improved, but it's a larger project.

Type: defect → enhancement
Priority: -- → P3
Summary: Should we just do a clobber build whenever python/mozbuild/mozbuild/backend/recursivemake.py is changed? → Perform a clobber build if build logic changes (recursivemake.py, etc)

Updates to recursivemake.py should already trigger a re-configure, which should end up with the build rebuilding most everything. It would be useful to know what failed before you had to clobber, because it's surprising it's happening in the first place.

You need to log in before you can comment on or make changes to this bug.