Remove "marionette.contentListener" and don't default to true for "marionette.debugging.clicktostart" when debugging
Categories
(Remote Protocol :: Marionette, task, P3)
Tracking
(firefox88 fixed)
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(2 files)
The preference is no longer needed. Necessary breakpoint could be set in the Marionette code before starting Firefox by adding debugger statements. Right now it's only annoying to have to click away those modal dialogs.
|
Assignee | |
Comment 1•3 years ago
|
||
Actually there is also marionette.contentListener, which is marked as deprecated:
Both got added via bug 1456050 and don't seem to be needed anymore.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Actually it would be good to keep the marionette.debugging.clicktostart preference but don't set it implicitly to true when --jsdebugger is passed. That would still allow users of Selenium / geckodriver to debug a Marionette session without having to download the code first.
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
Always getting a user prompt shown when debugging code in Marionette
is disturbing. Given that we usually use the "debugger;" statement
anyway, this prompt will not be useful by default.
But we should keep it to actually allow users of Marionette and
geckodriver to run a debug session without having to modify the
code first.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D107428
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e9fa8d73a47 [marionette] Don't enable "marionette.debugging.clicktostart" by default when --jsdebugger is used. r=marionette-reviewers,webdriver-reviewers,jdescottes,jgraham https://hg.mozilla.org/integration/autoland/rev/fdae009d0b38 [marionette] Remove unused "marionette.contentListener" preference. r=marionette-reviewers,jdescottes
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8e9fa8d73a47
https://hg.mozilla.org/mozilla-central/rev/fdae009d0b38
|
||
Updated•1 year ago
|
Description
•