Closed Bug 1697017 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27886 - Add WPTs for control characters in cookie lines

Categories

(Core :: Networking: Cookies, task, P4)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27886 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27886
Details from upstream follow.

b'Lily Chen <chlily@chromium.org>' wrote:

Add WPTs for control characters in cookie lines

This adds tests for control characters, both "terminator" characters
(\r\n\0) and other control characters, in cookie names and values.

Also a drive-by bugfix in existing name tests.

Bug: 1184409
Change-Id: If3634a5ebf2798467071493cf0f5e1996f81dde2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2733515
Reviewed-by: Steven Bingler \<bingler@chromium.org>
Commit-Queue: Lily Chen \<chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859868}

Component: web-platform-tests → Networking: Cookies
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 13 tests and 22 subtests

Status Summary

Firefox

OK : 13
PASS: 302
FAIL: 154

Safari

OK : 13
PASS: 230
FAIL: 226

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cookies/attributes/domain.sub.html
No cookie returned for domain mismatch (with domain mismatch as first domain attribute and second a bare attribute): FAIL (Safari: FAIL)
/cookies/attributes/invalid.html
Ignore Set-Cookie: = with other Set-Cookie headers: FAIL (Safari: FAIL)
Ignore name- and value-less Set-Cookie: ; bar: FAIL (Safari: FAIL)
/cookies/attributes/path-redirect.html
No cookie sent for redirected path mismatch with trailing '?' after unquoted Path: FAIL (Safari: PASS)
No cookie sent for redirected path mismatch with trailing '#' after unquoted Path: FAIL (Safari: PASS)
/cookies/name/name-ctl.html
Cookie with %x7f in name is rejected.: FAIL (Safari: FAIL)
Cookie with %x1 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x2 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x3 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x4 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x5 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x6 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x7 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x8 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x9 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xb after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xc after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xe after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xf after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x10 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x11 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x12 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x13 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x14 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x15 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x16 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x17 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x18 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x19 after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1a after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1b after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1c after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1d after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1e after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1f after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x7f after %x0 in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x2 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x3 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x4 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x5 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x6 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x7 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x8 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x9 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xb after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xc after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xe after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xf after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x10 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x11 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x12 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x13 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x14 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x15 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x16 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x17 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x18 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x19 after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1a after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1b after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1c after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1d after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1e after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1f after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x7f after %xa in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x2 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x3 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x4 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x5 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x6 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x7 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x8 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x9 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xb after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xc after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xe after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %xf after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x10 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x11 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x12 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x13 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x14 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x15 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x16 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x17 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x18 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x19 after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1a after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1b after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1c after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1d after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1e after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x1f after %xd in name is truncated.: FAIL (Safari: FAIL)
Cookie with %x7f after %xd in name is truncated.: FAIL (Safari: FAIL)
/cookies/name/name.html
Return the most recent nameless cookie, even if preceded by =, in addition to other valid cookie: FAIL (Safari: FAIL)
Use last value for cookies with identical names: FAIL (Safari: PASS)
Keep first-in, first-out name order: FAIL (Safari: PASS)
Keep first-in, first-out single-char name order: FAIL (Safari: PASS)
Keep non-alphabetic first-in, first-out name order: FAIL (Safari: FAIL)
Keep first-in, first-out order if comma-separated: FAIL (Safari: FAIL)
Set nameless cookie, given Set-Cookie: =test16: FAIL (Safari: FAIL)
Overwrite nameless cookie: FAIL (Safari: FAIL)
Ignore cookie with empty name and empty value: FAIL (Safari: FAIL)
Ignore cookie with no name or value: FAIL (Safari: FAIL)
Name is set as expected for a=test: FAIL (Safari: FAIL)
Name is set as expected for 1=test: FAIL (Safari: FAIL)
Name is set as expected for $=test: FAIL (Safari: FAIL)
Name is set as expected for !a=test: FAIL (Safari: FAIL)
Name is set as expected for @a=test: FAIL (Safari: FAIL)
Name is set as expected for #a=test: FAIL (Safari: FAIL)
Name is set as expected for $a=test: FAIL (Safari: FAIL)
Name is set as expected for %a=test: FAIL (Safari: FAIL)
Name is set as expected for ^a=test: FAIL (Safari: FAIL)
Name is set as expected for &a=test: FAIL (Safari: FAIL)
Name is set as expected for *a=test: FAIL (Safari: FAIL)
Name is set as expected for (a=test: FAIL (Safari: FAIL)
Name is set as expected for )a=test: FAIL (Safari: FAIL)
Name is set as expected for -a=test: FAIL (Safari: FAIL)
Name is set as expected for _a=test: FAIL (Safari: FAIL)
Name is set as expected for +=test: FAIL (Safari: FAIL)
Name is set as expected for "a=test: FAIL (Safari: FAIL)
Name is set as expected for "a=b"=test: FAIL (Safari: FAIL)
/cookies/value/value-ctl.html
Cookie with %x1 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x2 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x3 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x4 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x5 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x6 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x7 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x8 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x9 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %xb in value is rejected.: FAIL (Safari: FAIL)
Cookie with %xc in value is rejected.: FAIL (Safari: FAIL)
Cookie with %xe in value is rejected.: FAIL (Safari: FAIL)
Cookie with %xf in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x10 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x11 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x12 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x13 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x14 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x15 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x16 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x17 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x18 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x19 in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x1a in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x1b in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x1c in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x1d in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x1e in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x1f in value is rejected.: FAIL (Safari: FAIL)
Cookie with %x7f in value is rejected.: FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e4890ff8162
[wpt PR 27886] - Add WPTs for control characters in cookie lines, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d6abdacfb8c6
[wpt PR 27886] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.