1697022 - [wpt-sync] Sync PR 27921 - Fix 4:4:4 RGB software rendering. Use new libyuv matrix funcs.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27921 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27921
Details from upstream follow.

b'Dale Curtis <[e-mail]>' wrote:

Fix 4:4:4 RGB software rendering. Use new libyuv matrix funcs.

libyuv now has matrix functions which lets us greatly simplify
our PaintCanvasVideoRenderer code. They don't have a identity
matrix though for GBR content, so use libyuv::MergeARGBPlane
for 4:4:4 RGB content (gbr/bt709/iec61966_2_1).

These fixes allow us to pass new four-colors.mp4 rendering
tests for the WebCodecs pipeline.

This also exposed a bug where we were missing color spaces on
wrapped video frames.

Bug: 1184128
Test: New tests!

Change-Id: I5749d84815bdd9c640abad31e2a28089058a4034
Fixed: 444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2739259
Auto-Submit: Dale Curtis \<[e-mail]>
Reviewed-by: Thomas Guilbert \<[e-mail]>
Commit-Queue: Dale Curtis \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#860571}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a93e6e38a799554f486051cc382989b912d048d8

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
FAIL: 5

Chrome

OK : 1
PASS: 4
FAIL: 1

Safari

OK : 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/videoFrame-canvasImageSource.html
<video> and VideoFrame constructed VideoFrame: FAIL (Chrome: FAIL, Safari: FAIL)
CSSImageValue constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Image element constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
SVGImageElement constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)
Canvas element constructed VideoFrame: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9f27561f2a8
[wpt PR 27921] - Fix 4:4:4 RGB software rendering. Use new libyuv matrix funcs., a=testonly

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a9f27561f2a8