1697038 - [wpt-sync] Sync PR 27885 - SWRegisterJob::Equals should compare ScriptType

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27885 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27885
Details from upstream follow.

b'Ghazale Hosseinabadi <[e-mail]>' wrote:

SWRegisterJob::Equals should compare ScriptType

When checking two SWRegisterJobs are equal, we should also check
equality of ScriptType.

Bug: 1168832
Change-Id: I0f8a7de3b09f7d2a0c90ce4ebe73ca23cc61b26b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2728489
Commit-Queue: Ghazale Hosseinabadi \<[e-mail]>
Reviewed-by: Kenichi Ishibashi \<[e-mail]>
Reviewed-by: Hiroki Nakagawa \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#860732}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 27885 applied with additional changes from upstream: 980c61816c5c577122558df18497c5971bc5741e

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=538dec6b4e3d95424bec905e5a882e46b640f4c0

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 1[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows7-32-opt, GitHub] 2[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug]
FAIL: 1[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] 2[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows7-32-opt, GitHub]

Chrome

OK : 1
PASS: 1
FAIL: 2

Safari

OK : 1
PASS: 2
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/service-workers/service-worker/registration-schedule-job.https.html
different updateViaCache: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-opt, Gecko-windows7-32-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug] (Chrome: FAIL, Safari: PASS)
different type: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e5f1a604243
[wpt PR 27885] - SWRegisterJob::Equals should compare ScriptType, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4a53e49952e8
[wpt PR 27885] - Update wpt metadata, a=testonly

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2e5f1a604243
https://hg.mozilla.org/mozilla-central/rev/4a53e49952e8