Closed Bug 1697058 Opened 5 years ago Closed 5 years ago

Perma toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL

Categories

(Toolkit :: General, defect, P5)

defect

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- fixed

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: intermittent-failure)

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=332447612&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LIN7QUMAR4WpC7cQ6GeRaQ/runs/0/artifacts/public/logs/live_backing.log


[task 2021-03-08T22:05:42.339Z]  0:08.23 ============================= test session starts ==============================
[task 2021-03-08T22:05:42.339Z]  0:08.23 platform linux2 -- Python 2.7.17, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/python-test/bin/python
[task 2021-03-08T22:05:42.340Z]  0:08.23 rootdir: /builds/worker/checkouts/gecko, inifile: /builds/worker/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2021-03-08T22:05:42.340Z]  0:08.23 collecting ... collected 28 items
[task 2021-03-08T22:05:42.340Z]  0:08.23 
[task 2021-03-08T22:05:42.340Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestHyphensToCamelCase::test_simple_cases PASSED
[task 2021-03-08T22:05:42.343Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestExceptionGroup::test_str_indentation_of_grouped_lines PASSED
[task 2021-03-08T22:05:42.343Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureGateException::test_repr_no_file PASSED
[task 2021-03-08T22:05:42.343Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureGateException::test_repr_with_file PASSED
[task 2021-03-08T22:05:42.343Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureGateException::test_str_no_file PASSED
[task 2021-03-08T22:05:42.343Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureGateException::test_str_with_file PASSED
[task 2021-03-08T22:05:42.343Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_empty_feature PASSED
[task 2021-03-08T22:05:42.343Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_invalid_toml PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_missing_file PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureSchema::test_extra_keys_not_allowed PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureSchema::test_minimal_valid PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureSchema::test_nonempty_keys PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestFeatureSchema::test_required_fields PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_default_value_default TEST-UNEXPECTED-FAIL
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_default_value_override_configured_value PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_default_value_override_constant PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_hyphenation_to_snake_case PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_preference_default PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ExpandFeatureTests::test_preference_override PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_compound_keys PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_default_key_is_required PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_expands_single_values PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_invalid_keys_rejected PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_multiple_keys PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::ProcessConfiguredValueTests::test_simple_key PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::MainTests::test_it_outputs_json TEST-UNEXPECTED-FAIL
[task 2021-03-08T22:05:42.344Z]  0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::MainTests::test_it_returns_1_for_errors PASSED
[task 2021-03-08T22:05:42.344Z]  0:08.24 
[task 2021-03-08T22:05:42.344Z]  0:08.24 =================================== FAILURES ===================================
[task 2021-03-08T22:05:42.344Z]  0:08.24 _______________________ TestProcessFiles.test_valid_file _______________________
[task 2021-03-08T22:05:42.344Z]  0:08.24 
[task 2021-03-08T22:05:42.344Z]  0:08.24 self = <test_gen_feature_definitions.TestProcessFiles testMethod=test_valid_file>
[task 2021-03-08T22:05:42.344Z]  0:08.24 
[task 2021-03-08T22:05:42.344Z]  0:08.24     def test_valid_file(self):
[task 2021-03-08T22:05:42.344Z]  0:08.24         filename = make_test_file_path("good")
[task 2021-03-08T22:05:42.344Z]  0:08.24         result = process_files([filename])
[task 2021-03-08T22:05:42.344Z]  0:08.24 >       assert result == {
[task 2021-03-08T22:05:42.344Z]  0:08.24             "demo-feature": {
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "id": "demo-feature",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "title": "Demo Feature",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "description": "A no-op feature to demo the feature gate system.",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "restartRequired": False,
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "preference": "foo.bar.baz",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "type": "boolean",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "bugNumbers": [1479127],
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "isPublic": {"default": True},
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "defaultValue": {"default": False},
[task 2021-03-08T22:05:42.344Z]  0:08.24             },
[task 2021-03-08T22:05:42.344Z]  0:08.24             "minimal-feature": {
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "id": "minimal-feature",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "title": "Minimal Feature",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "description": "The smallest feature that is valid",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "restartRequired": True,
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "preference": "features.minimal-feature.enabled",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "type": "boolean",
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "bugNumbers": [1479127],
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "isPublic": {"default": False},
[task 2021-03-08T22:05:42.344Z]  0:08.24                 "defaultValue": {"default": False},
[task 2021-03-08T22:05:42.344Z]  0:08.24             },
[task 2021-03-08T22:05:42.344Z]  0:08.24         }
[task 2021-03-08T22:05:42.344Z]  0:08.24 E       AssertionError: assert {'demo-featur...eature', ...}} == {'demo-feature...eature', ...}}
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         Common items:
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         {'demo-feature': {u'bugNumbers': [1479127],
[task 2021-03-08T22:05:42.344Z]  0:08.24 E                           u'defaultValue': {'default': False},
[task 2021-03-08T22:05:42.344Z]  0:08.24 E                           u'description': u'A no-op feature to demo the feature gate system.',
[task 2021-03-08T22:05:42.344Z]  0:08.24 E                           'id': u'demo-feature',
[task 2021-03-08T22:05:42.344Z]  0:08.24 E                           u'isPublic': {'default': True},
[task 2021-03-08T22:05:42.344Z]  0:08.24 E                           u'preference': u'foo.bar.baz',
[task 2021-03-08T22:05:42.344Z]  0:08.24 E                           u'restartRequired': False,
[task 2021-03-08T22:05:42.344Z]  0:08.24 E                           u'title': u'Demo Feature',
[task 2021-03-08T22:05:42.344Z]  0:08.24 E                           u'type': u'boolean'}}
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         Differing items:
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         {'minimal-feature': {'bugNumbers': [1479127], 'defaultValue': {'default': None}, 'description': 'The smallest feature that is valid', 'id': 'minimal-feature', ...}} != {'minimal-feature': {'bugNumbers': [1479127], 'defaultValue': {'default': False}, 'description': 'The smallest feature that is valid', 'id': 'minimal-feature', ...}}
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         Full diff:
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         - {u'demo-feature': {u'bugNumbers': [1479127],
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         ?  -                 -
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         + {'demo-feature': {'bugNumbers': [1479127],
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         -                    u'defaultValue': {'default': False},
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         ?                   --
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         +                   'defaultValue': {'default': False},
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         -                    u'description': u'A no-op feature to demo the feature gate system.',
[task 2021-03-08T22:05:42.344Z]  0:08.24 E         ?                   --               -
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         +                   'description': 'A no-op feature to demo the feature gate system.',
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         -                    'id': u'demo-feature',
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         ? -                        -
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         +                   'id': 'demo-feature',
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         -                    u'isPublic': {'default': True},
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         ?                   --
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         +                   'isPublic': {'default': True},
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         -                    u'preference': u'foo.bar.baz',
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         ?                   --              -
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         +                   'preference': 'foo.bar.baz',
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         -                    u'restartRequired': False,
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         ?                   --
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         +                   'restartRequired': False,
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         -                    u'title': u'Demo Feature',
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         ?                   --         -
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         +                   'title': 'Demo Feature',
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         -                    u'type': u'boolean'},
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         ?                   --        -
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         +                   'type': 'boolean'},
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         -  u'minimal-feature': {u'bugNumbers': [1479127],
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         ?  -                    -
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         +  'minimal-feature': {'bugNumbers': [1479127],
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         -                       'defaultValue': {'default': None},
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         ? -                                                 ^^^
[task 2021-03-08T22:05:42.345Z]  0:08.24 E         +                      'defaultValue': {'default': False},
[task 2021-03-08T22:05:42.346Z]  0:08.24 E         ?                                                  ^^^^
[task 2021-03-08T22:05:42.346Z]  0:08.24 E         -                       u'description': u'The smallest feature that is valid',
[task 2021-03-08T22:05:42.346Z]  0:08.24 E         ?                      --               -
[task 2021-03-08T22:05:42.346Z]  0:08.24 E         +                      'description': 'The smallest feature that is valid',
[task 2021-03-08T22:05:42.346Z]  0:08.24 E         -                       'id': u'minimal-feature',
[task 2021-03-08T22:05:42.346Z]  0:08.24 E         ? -                           -
[task 2021-03-08T22:05:42.346Z]  0:08.24 E         +                      'id': 'minimal-feature',
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         -                       'isPublic': {'default': False},
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         ? -
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         +                      'isPublic': {'default': False},
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         -                       'preference': 'features.minimal-feature.enabled',
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         ? -
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         +                      'preference': 'features.minimal-feature.enabled',
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         -                       u'restartRequired': True,
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         ?                      --
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         +                      'restartRequired': True,
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         -                       u'title': u'Minimal Feature',
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         ?                      --         -
[task 2021-03-08T22:05:42.347Z]  0:08.24 E         +                      'title': 'Minimal Feature',
[task 2021-03-08T22:05:42.348Z]  0:08.24 E         -                       u'type': u'boolean'}}
[task 2021-03-08T22:05:42.348Z]  0:08.24 E         ?                      --        -
[task 2021-03-08T22:05:42.348Z]  0:08.24 E         +                      'type': 'boolean'}}
[task 2021-03-08T22:05:42.348Z]  0:08.24 
[task 2021-03-08T22:05:42.348Z]  0:08.24 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py:109: AssertionError```
Flags: needinfo?(bigiri)
Summary: Intermittent [tier2] 0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL → Intermittent Perma [tier2] 0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL

Fixed by backout of bug 1692122.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Summary: Intermittent Perma [tier2] 0:08.23 toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL → Perma toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL
Target Milestone: --- → 88 Branch
Flags: needinfo?(bigiri)
You need to log in before you can comment on or make changes to this bug.