1697147 - Intermittent devtools/shared/resources/tests/browser_target_list_various_descriptors.js | Test timed out -

Status: RESOLVED FIXED

(DevTools :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=332500488&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CXEIBgM7S2ihKhpDBoHj0w/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CXEIBgM7S2ihKhpDBoHj0w/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2021-03-09T09:03:05.667Z] 09:03:05     INFO - TEST-PASS | devtools/shared/resources/tests/browser_target_list_various_descriptors.js | This is flagged as top level - 
[task 2021-03-09T09:03:05.668Z] 09:03:05     INFO - Test TargetList against parent process descriptor
[task 2021-03-09T09:03:05.668Z] 09:03:05     INFO - Buffered messages finished
[task 2021-03-09T09:03:05.668Z] 09:03:05     INFO - TEST-UNEXPECTED-FAIL | devtools/shared/resources/tests/browser_target_list_various_descriptors.js | Test timed out - 
[task 2021-03-09T09:03:05.670Z] 09:03:05     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-03-09T09:03:05.670Z] 09:03:05     INFO - TEST-UNEXPECTED-FAIL | devtools/shared/resources/tests/browser_target_list_various_descriptors.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2021-03-09T09:03:05.670Z] 09:03:05     INFO - Stack trace:
[task 2021-03-09T09:03:05.670Z] 09:03:05     INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-03-09T09:03:05.670Z] 09:03:05     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:cleanup:316
[task 2021-03-09T09:03:05.671Z] 09:03:05     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-03-09T09:03:05.676Z] 09:03:05     INFO - TEST-UNEXPECTED-FAIL | devtools/shared/resources/tests/browser_target_list_various_descriptors.js | Uncaught exception received from previously timed out test - at resource://devtools/shared/protocol/Front.js:99 - Error: Connection closed, pending request to server0.conn2.watcher28, type watchTargets failed
[task 2021-03-09T09:03:05.676Z] 09:03:05     INFO - ```

Comment 1

[Natalia Csoregi [:nataliaCs]]

Upgraded to intermittent tier 1: https://treeherder.mozilla.org/jobs?repo=autoland&revision=5c5cb052e61bd4829c55f313268b8a9a3490deab&searchStr=dt&group_state=expanded&selectedTaskRun=ICPfvlfMQkyxKUAjIqAeuA.0

Comment 2

[Natalia Csoregi [:nataliaCs]]

Alexandre, any chance you could take a look at this when you have the time?
Thank you.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1696957

Comment 4

[Alexandre Poirot [:ochameau]]

I tried to reproduce via --verify but this doesn't reproduce frequently. I'll test again later.

Comment 5

[Intermittent Failures Robot]

24 failures in 4622 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 20
• try: 2
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64: 7
  • debug: 4
  • opt: 3
• macosx1014-64-qr: 6
  • debug: 6
• linux1804-64-shippable: 3
  • opt: 3
• linux1804-64-asan: 7
  • opt: 7
• windows10-64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1697147&startday=2021-03-08&endday=2021-03-14&tree=all

Comment 6

[Intermittent Failures Robot]

26 failures in 4257 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

This is the #46 most frequent failure this week.

Repository breakdown:

• autoland: 21
• mozilla-central: 2
• try: 3

Platform and build breakdown:

• macosx1014-64-qr: 7
  • debug: 6
  • opt: 1
• linux1804-64-shippable: 4
  • opt: 4
• linux1804-64: 12
  • opt: 8
  • debug: 4
• linux1804-64-qr: 1
  • opt: 1
• windows10-64-qr: 1
  • debug: 1
• linux1804-64-devedition: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1697147&startday=2021-03-15&endday=2021-03-21&tree=all

Comment 7

[Alexandre Poirot [:ochameau]]

I'm able to reproduce a few errors now, thanks this this command:

$ ./mach mochitest --headless devtools/shared/commands/target/tests/browser_target_list_tab_workers.js devtools/shared/commands/target/tests/browser_target_list_various_descriptors.js --repeat 10

I've also seen the following exception happening frequently:

 0:34.71 GECKO(33480) console.error: "Tried to send a 'getTarget' method reply on an already destroyed actor 'workerDescriptor'"
 1:18.12 INFO Failed to retrieve MOZ_UPLOAD_DIR env var
 1:18.18 GECKO(33480) console.error: "Error when attaching target:" (new Error("Connection closed, pending request to server0.conn10.workerDescriptor34, type getTarget failed\n\nRequest stack:\nrequest@resource://devtools/shared/protocol/Front.js:285:14\ngenerateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:46:19\ngetTarget/this._attach<@resource://devtools/client/fronts/descriptors/worker.js:92:44\nasync*getTarget@resource://devtools/client/fronts/descriptors/worker.js:105:7\nattach@resource://devtools/client/fronts/descriptors/worker.js:64:17\n_attachAndInitThread@resource://devtools/client/fronts/targets/target-mixin.js:477:20\nattachAndInitThread@resource://devtools/client/fronts/targets/target-mixin.js:456:40\n_onTargetAvailable@resource://devtools/shared/commands/target/target-command.js:166:25\n_processNewWorkerTarget@resource://devtools/shared/resources/legacy-target-watchers/legacy-workers-watcher.js:137:20\n_workerListChanged/promises<@resource://devtools/shared/resources/legacy-target-watchers/legacy-workers-watcher.js:112:12\n_workerListChanged@resource://devtools/shared/resources/legacy-target-watchers/legacy-workers-watcher.js:111:30\nasync*_onProcessAvailable@resource://devtools/shared/resources/legacy-target-watchers/legacy-workers-watcher.js:38:16\nlisten@resource://devtools/shared/resources/legacy-target-watchers/legacy-workers-watcher.js:157:18\nasync*startListening@resource://devtools/shared/commands/target/target-command.js:325:47\nasync*testParentProcess@chrome://mochitests/content/browser/devtools/shared/commands/target/tests/browser_target_list_various_descriptors.js:40:20\nasync*@chrome://mochitests/content/browser/devtools/shared/commands/target/tests/browser_target_list_various_descriptors.js:26:9\nAsync*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1089:34\nTester_execTest@chrome://mochikit/content/browser-test.js:1129:11\nnextTest/<@chrome://mochikit/content/browser-test.js:949:14\nSimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1037:23\n", "resource://devtools/shared/protocol/Front.js", 99))

This is related to bug 1631451 and the worker descriptor isn't immediately/correctly destroyed so that the getTarget pending request isn't rejected and stays pending. This is most likely related to worker descriptor's destroy not destroying the front interface as soon as descriptor-destroyed event is received.

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1697147 - [devtools] Handle destroyed content processes when calling WatcherActor.watchTargets.

Apply the same technique as in addWatcherDataEntry in order
to better handle the case when a content process is being destroyed
while we call one of these two methods.

Comment 9

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dae9c99386562552d87d2580f366c740f462f8a

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d73b25e24e9e
[devtools] Handle destroyed content processes when calling WatcherActor.watchTargets. r=nchevobbe

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d73b25e24e9e

Comment 12

[Intermittent Failures Robot]

5 failures in 3967 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1
• autoland: 3
• mozilla-central: 1

Platform and build breakdown:

• macosx1014-64-qr: 2
  • debug: 2
• linux1804-64: 1
  • opt: 1
• linux1804-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1697147&startday=2021-03-22&endday=2021-03-28&tree=all