Closed Bug 1697182 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27945 - [markers] Fix crash with negative available-size.

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27945 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27945
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[markers] Fix crash with negative available-size.

Previously code in NGUnpositionedListMarker was able to produce an
available_size \< 0, which triggered a DCHECK in the NGBfcRect.

This switches the calculation to the available-size on the
container builder.

Bug: 1183869
Change-Id: I61f6d95c8edbe14b71fd7577e73b287ed5e4f038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2743418
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Auto-Submit: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861025}

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c35c716318ac
[wpt PR 27945] - [markers] Fix crash with negative available-size., a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.