1697183 - [wpt-sync] Sync PR 27937 - Resolve CSSInvalidVariableValues earlier

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27937 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27937
Details from upstream follow.

b'Anders Hartvoll Ruud <[e-mail]>' wrote:

Resolve CSSInvalidVariableValues earlier

Parts of the animations code is not prepared to handle
CSSInvalidVariableValues for registered custom properties. (They are
exposed as nullptr via the CSSPropertyName-overload of StyleCascade::
Resolve). Hence we do the CSSInvalidVariableValue->CSSUnsetValue for
relevant custom properties inside StyleCascade, such that this
conversion is seen by both CustomProperty and the animations code.

Fixed: 1185524
Bug: 1185745
Change-Id: If7bd6a34f51ed9af2f63f14434794cacb541e90b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2741062
Reviewed-by: Xiaocheng Hu \<[e-mail]>
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#861067}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=45a6cd2a1fd9084148d118a10cb980a8bcb7290f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/animate-invalid.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Do not crash when animating to unresolved var(): FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/css/css-properties-values-api/animate-invalid.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdb93f608926
[wpt PR 27937] - Resolve CSSInvalidVariableValues earlier, a=testonly

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/cdb93f608926