Closed Bug 1697191 Opened 9 months ago Closed 9 months ago

Remove remaining built-in page action widgets

Categories

(Firefox :: Address Bar, task, P2)

task
Points:
2

Tracking

()

VERIFIED FIXED
88 Branch
Iteration:
88.2 - Mar 8 - Mar 21
Tracking Status
firefox88 --- verified

People

(Reporter: mstriemer, Assigned: adw)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [proton-address-bar])

Attachments

(1 file)

Page actions should be reserved for add-ons, bookmarking and reader mode. Therefore, the other built-in actions such as Pin Tab, Copy Link, Email Link, Send Tab to Device, and Share should be removed.

They are added in PageActions.jsm and should only be added when browser.proton.urlbar.enabled is true.

Add search engine, Pocket and Screenshots are being removed elsewhere.

https://searchfox.org/mozilla-central/rev/5a66c4b4a41ab78a87c30c9db0d93c732c534402/browser/modules/PageActions.jsm#1176-1234,1260-1319

Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 88.2 - Mar 8 - Mar 21
Points: --- → 2
Keywords: helpwanted

Could you please also remove Add Engine here? Bug 1691474 is just going to add new access points, it seems to make more sense to hide this option here along with the others.

I followed up on Slack, but just so it's here in the bug too, this patch does remove Add Engine in Proton -- it removes everything except for the bookmark action.

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b880dd414928
Remove remaining built-in page actions when Proton is enabled. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Regressions: 1701544
Regressions: 1701548

Marking the issue as verified fixed. This has been covered in the address bar sign off tests. Marking as verified in Fx89.0a1 and Fx88.0b9 on Windows 10 and Ubuntu 18.04. The mentioned buttons are removed from the address bar.

Status: RESOLVED → VERIFIED
Regressions: 1706232
Regressions: 1709781
No longer regressions: 1706232
You need to log in before you can comment on or make changes to this bug.