1697191 - Remove remaining built-in page action widgets

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Mark Striemer [:mstriemer]]

Page actions should be reserved for add-ons, bookmarking and reader mode. Therefore, the other built-in actions such as Pin Tab, Copy Link, Email Link, Send Tab to Device, and Share should be removed.

They are added in PageActions.jsm and should only be added when browser.proton.urlbar.enabled is true.

Add search engine, Pocket and Screenshots are being removed elsewhere.

https://searchfox.org/mozilla-central/rev/5a66c4b4a41ab78a87c30c9db0d93c732c534402/browser/modules/PageActions.jsm#1176-1234,1260-1319

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1697191 - Remove remaining built-in page actions when Proton is enabled.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=97e238b141fa4760432f516693bd420e162a7c06

Comment 3

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1ffcef0a9b2234e17ce1a9278943fcefc4c131b

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dfb6877d50b39fdef0423b2f860f3ae1c4650a0

Comment 5

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e973e1d118e9757be0c238d14599e9bc0b23b709

Comment 6

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=83b60048b3a6093ba6083c17ccaae28e048ed1fc

Comment 7

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9997e99ee57b5d11794eb96bb0a4c2d51b67643

Comment 8

[Drew Willcoxon :adw]

Proton disabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5890811a31a9c0a464488a6baf7515589d28ffe1

Proton enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e41871e7748df01bc074ee717cb063b09efd94b3

Comment 9

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0ef79bff7c13f17a65bad5d59c94efc96734bcb

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Could you please also remove Add Engine here? Bug 1691474 is just going to add new access points, it seems to make more sense to hide this option here along with the others.

Comment 11

[Drew Willcoxon :adw]

I followed up on Slack, but just so it's here in the bug too, this patch does remove Add Engine in Proton -- it removes everything except for the bookmark action.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b880dd414928
Remove remaining built-in page actions when Proton is enabled. r=Gijs

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b880dd414928

Comment 14

[Cristian Baica [:cbaica], Release Desktop QA]

Marking the issue as verified fixed. This has been covered in the address bar sign off tests. Marking as verified in Fx89.0a1 and Fx88.0b9 on Windows 10 and Ubuntu 18.04. The mentioned buttons are removed from the address bar.