1697222 - Show window modal for existing users on upgrade highlighting Proton improvements (with new 24px icons)

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

Attachment: wip example screen

I believe this can reuse the chrome window modal dialogs added in bug 1685313. Where we open up a MODAL_TYPE_INTERNAL_WINDOW (the default used by gDialogBox) to a new html page that implements the desired screen(s).

• The desired behavior is to only allow dismissing via the Dismiss button within the modal.
• There may be multiple pages/screens with in-modal navigation.
• The 4 theme selections + 1 checkbox "keep previous" should act as a 5 radio button input (i.e., only one can be selected).
• Ideally for theme selection screen (or in general), tabs/toolbar area are not shaded gray so that the selected theme is fully visible

Comment 1

[Ed Lee :Mardak]

Maybe we should split this to a separate bug to handle when the modal is shown and keep this bug focused on the content of the modal?

Some notes on triggering:

• this replaces the whatsnew tab - bug 1697530
• the modal should only be shown when there's something relevant, so focused on major releases
• show the modal content once, so skip if there's no new content and user has already seen it
• we only keep the most recent content checked in and strings should land in nightly
• there is an existing "postUpdateCustomPage" policy although unclear if it should be reused/ignored/duplicated?

Triggering code should probably be around https://searchfox.org/mozilla-central/rev/2b99ea2e97eef00a8a1c7e24e5fe51ab5304bc42/browser/components/BrowserContentHandler.jsm#670-691

Comment 2

[Mike Kaply [:mkaply]]

We should use existing policy to know show this. Probably whatever flips browser.aboutwelcome.enabled. There's a bug in the current code - bug 1697566 - I'll fix that.

Comment 3

[Ed Lee :Mardak]

Sounds like we'll go with tab-modal dialog instead of a window-modal dialog so that theme changes would be fully visible (instead of faded by the backdrop). So probably something like gBrowser.getTabDialogBox().open("chrome://browser/content/updatePage.html")

This would allow the user to switch tabs, navigate, interact with toolbar, etc. instead of forcing some interaction.

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1697222 - Add window modal dialog for existing users on upgrade highlighting Proton improvements r=pdahiya!

Comment 5

[Ed Lee :Mardak]

Attachment: Bug 1697222 - Show upgrade dialog without conflicting with existing default browser prompt. r?andreio,k88hudson

Depends on D110330

Comment 6

[Ed Lee :Mardak]

Attachment: example first screen on windows is default browser but not pinned

Comment 7

[Ed Lee :Mardak]

Attachment: example theme screen on mac dark with existing theme

Comment 8

[Ed Lee :Mardak]

Attachment: Bug 1697222 - Record telemetry events for various upgrade dialog interactions. r?nanj,pdahiya

Depends on D111041

Comment 9

[Ed Lee :Mardak]

Looks like we'll be using a new set of svg icons specially designed to be used at 24px

Comment 10

[Ed Lee :Mardak]

Attachment: example 4 primary buttons on first screen

Comment 11

[Ed Lee :Mardak]

Attachment: Data Review Request Form

Comment 12

[Ed Lee :Mardak]

Attachment: finalized windows.png

Comment 14

[Chris H-C :chutten]

Comment on attachment 9214970 [details]
Data Review Request Form

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Ed Lee is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---

Result: datareview+

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d8df052a780
Add window modal dialog for existing users on upgrade highlighting Proton improvements r=pdahiya,flod,sfoster
https://hg.mozilla.org/integration/autoland/rev/6c72185b0f44
Show upgrade dialog without conflicting with existing default browser prompt. r=andreio
https://hg.mozilla.org/integration/autoland/rev/7388f5dc0e03
Record telemetry events for various upgrade dialog interactions. r=nanj

Comment 16

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4d8df052a780
https://hg.mozilla.org/mozilla-central/rev/6c72185b0f44
https://hg.mozilla.org/mozilla-central/rev/7388f5dc0e03

Comment 17

[Ed Lee :Mardak]

For those looking to test this out on nightly, it won't work yet until an upgradeDialog record is reviewed and published showing up at https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/nimbus-desktop-defaults/records

Comment 18

[Ed Lee :Mardak]

Attachment: nightly upgrade showing upgrade dialog modal on mac

(In reply to Ed Lee :Mardak from comment #17)

For those looking to test this out on nightly, it won't work yet until an upgradeDialog record is reviewed and published showing up at https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/nimbus-desktop-defaults/records

The record is live, so upgrade from a previous nightly to see or manually set browser.startup.homepage_override.mstone to "88.0" and restart nightly.

Comment 19

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the modal is correctly displayed and that the modal icons are 24px by doing the following:

• Upgraded the browser from Firefox Nightly 87.0a1 to the latest Firefox Nightly 89.0a1 version (Build ID: 20210419094740).
• Set the browser.startup.homepage_override.mstone pref value to 88.0 and restart the browser using the latest Firefox Nightly 89.0a1 (Build ID: 20210419094740).

I've verified these on Windows 10 x64, macOS 11.2.3, and Ubuntu Linux 20.04 x64.