Open Bug 1697222 Opened 1 month ago Updated 8 hours ago

Show window modal for existing users on upgrade highlighting Proton improvements (with new 24px icons)

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

ASSIGNED
Iteration:
89.2 - Apr 5 - Apr 18

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-onboarding] [proton-icons] )

Attachments

(8 files)

Attached image wip example screen

I believe this can reuse the chrome window modal dialogs added in bug 1685313. Where we open up a MODAL_TYPE_INTERNAL_WINDOW (the default used by gDialogBox) to a new html page that implements the desired screen(s).

  • The desired behavior is to only allow dismissing via the Dismiss button within the modal.
  • There may be multiple pages/screens with in-modal navigation.
  • The 4 theme selections + 1 checkbox "keep previous" should act as a 5 radio button input (i.e., only one can be selected).
  • Ideally for theme selection screen (or in general), tabs/toolbar area are not shaded gray so that the selected theme is fully visible
See Also: → 1697530

Maybe we should split this to a separate bug to handle when the modal is shown and keep this bug focused on the content of the modal?

Some notes on triggering:

  • this replaces the whatsnew tab - bug 1697530
  • the modal should only be shown when there's something relevant, so focused on major releases
  • show the modal content once, so skip if there's no new content and user has already seen it
  • we only keep the most recent content checked in and strings should land in nightly
  • there is an existing "postUpdateCustomPage" policy although unclear if it should be reused/ignored/duplicated?

Triggering code should probably be around https://searchfox.org/mozilla-central/rev/2b99ea2e97eef00a8a1c7e24e5fe51ab5304bc42/browser/components/BrowserContentHandler.jsm#670-691

We should use existing policy to know show this. Probably whatever flips browser.aboutwelcome.enabled. There's a bug in the current code - bug 1697566 - I'll fix that.

Sounds like we'll go with tab-modal dialog instead of a window-modal dialog so that theme changes would be fully visible (instead of faded by the backdrop). So probably something like gBrowser.getTabDialogBox().open("chrome://browser/content/updatePage.html")

This would allow the user to switch tabs, navigate, interact with toolbar, etc. instead of forcing some interaction.

No longer depends on: 1685313
Summary: Show window modal for existing users on upgrade highlighting Proton improvements → Show tab modal for existing users on upgrade highlighting Proton improvements
Whiteboard: [proton-onboarding]
Iteration: 88.2 - Mar 8 - Mar 21 → 89.1 - Mar 22 - Apr 4
Summary: Show tab modal for existing users on upgrade highlighting Proton improvements → Show window modal for existing users on upgrade highlighting Proton improvements
Attachment #9212658 - Attachment description: WIP: Bug 1697222 - Show tab modal for existing users on upgrade highlighting Proton improvements → WIP: Bug 1697222 - Show window modal for existing users on upgrade highlighting Proton improvements
Status: NEW → ASSIGNED
Iteration: 89.1 - Mar 22 - Apr 4 → 89.2 - Apr 5 - Apr 18
Attachment #9212658 - Attachment description: WIP: Bug 1697222 - Show window modal for existing users on upgrade highlighting Proton improvements → WIP: Bug 1697222 - Show tab modal for existing users on upgrade highlighting Proton improvements
Attachment #9212658 - Attachment description: WIP: Bug 1697222 - Show tab modal for existing users on upgrade highlighting Proton improvements → WIP: Bug 1697222 - Show window modal for existing users on upgrade highlighting Proton improvements
Attachment #9212658 - Attachment description: WIP: Bug 1697222 - Show window modal for existing users on upgrade highlighting Proton improvements → Bug 1697222 - Add window modal dialog for existing users on upgrade highlighting Proton improvements r=pdahiya!
Blocks: proton-icons
Summary: Show window modal for existing users on upgrade highlighting Proton improvements → Show window modal for existing users on upgrade highlighting Proton improvements (with all-tabs.svg icon)
Whiteboard: [proton-onboarding] → [proton-onboarding] [proton-icons]

Looks like we'll be using a new set of svg icons specially designed to be used at 24px

Summary: Show window modal for existing users on upgrade highlighting Proton improvements (with all-tabs.svg icon) → Show window modal for existing users on upgrade highlighting Proton improvements (with new 24px icons)
Attachment #9213980 - Attachment description: WIP: Bug 1697222 - Show upgrade dialog without conflicting with existing default browser prompt. → Bug 1697222 - Show upgrade dialog without conflicting with existing default browser prompt. r?andreio,k88hudson
Attachment #9214462 - Attachment description: WIP: Bug 1697222 - Record telemetry events for various upgrade dialog interactions → Bug 1697222 - Record telemetry events for various upgrade dialog interactions. r?nanj,pdahiya
Attachment #9214970 - Flags: data-review?(chutten)
You need to log in before you can comment on or make changes to this bug.