1697249 - Unable to write posts/comments containing mentions on linkedin.com

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Ksenia Berezina [:ksenia]]

This was initially reported in https://github.com/webcompat/web-bugs/issues/67604

Steps to reproduce:

1. Log in to your LinkedIn account and proceed to https://www.linkedin.com/feed/ in Firefox Nightly 88.0a1 / Firefox release
2. Under any post press "Comment" button to display contenteditable box
3. Type "@" to trigger autocomplete with your friends list
4. Select any friend from the list to "mention" them and press Space
5. Type any message and observe the text

Actual:
Text is bold as it's a part of the mention

Expected:
Text is in normal font

This behavior results in an error when trying to post the comment. There is a video recorder by the initial reporter https://www.youtube.com/watch?v=cO-ojh7whKo

From mozregression:

27:02.96 INFO: Narrowed integration regression window from [687d3f79, c5fb8455] (3 builds) to [bd0fd84d, c5fb8455] (2 builds) (~1 steps left)
27:02.96 INFO: No more integration revisions, bisection finished.
27:02.96 INFO: Last good revision: bd0fd84dbf437b7f0cddacd51520176c6f4dec2e
27:02.96 INFO: First bad revision: c5fb8455ae1a6a29bb7d1d9c093f5ca48e294f5d
27:02.96 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bd0fd84dbf437b7f0cddacd51520176c6f4dec2e&tochange=c5fb8455ae1a6a29bb7d1d9c093f5ca48e294f5d

Comment 1

[Ksenia Berezina [:ksenia]]

Attachment: 67604.html

I've created a reduced test case and I think the problem here is that there is an additional <span> element is added after the link (with the same classname as the link) and it's not what the site expects

Comment 2

[Ksenia Berezina [:ksenia]]

Hi Masayuki, would you be able to take a look at this?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This breaks a major SNS, so, I should fix ASAP.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1697249 - Stop creating `<span>` element for keeping same style as the link when the link will be unlinked r=m_kato!

When typing at edge of a link, editor splits the link element at the edge (i.e.,
creating an empty link element). Then, unlink the new link element (i.e.,
clearing the "link style"). At this time, class attribute and style
attribute are cloned to new <span> element for keeping the original style.
However, in this case, other browsers discard the specified style of the link.

On the other hand, when unlinking a link with execCommand("unlink"), the
other browsers keep specified style coming from style attribute.

Therefore, this patch adds new state to PropItem, which indicates whether
the class and style attribute should be cloned or discarded. And then,
when preparing for inserting text, this patch makes it pass to the utility
method.

For better compatibility, we should stop cloning class attribute, but not
in this bug because this patch should be minimized for requesting uplift to
beta channel.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fae7c1c56f0f
Stop creating `<span>` element for keeping same style as the link when the link will be unlinked r=m_kato

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28021 for changes under testing/web-platform/tests

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

Please request beta uplift ASAP if you think this is important and safe enough (it would likely land directly into the 87 release candidate).

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fae7c1c56f0f

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Julien Cristau [:jcristau] from comment #7)

Please request beta uplift ASAP if you think this is important and safe enough (it would likely land directly into the 87 release candidate).

Hmm, then, I think that it's too risky to up lift. Thank you for your attention.

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot